Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile home screen #70

Merged
merged 9 commits into from
Nov 27, 2024
Merged

Mobile home screen #70

merged 9 commits into from
Nov 27, 2024

Conversation

cgjohn
Copy link
Contributor

@cgjohn cgjohn commented Nov 26, 2024 •
edited
Loading

image

UI Kit changes:

  • Updates Stack components to take align and justify like the Chakra elements do
  • Updates Text to take an alignment prop
  • Adds html.div to the Button component to be decorative if no onClick is passed in
  • Adds button styleVariants

dguenther
dguenther approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@dguenther dguenther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs the package-lock.json to be committed, but after that this looks good to me!

@dgca dgca merged commit e262516 into main Nov 27, 2024
2 checks passed
@dgca dgca deleted the mobile-home-screen branch November 27, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgca dgca dgca left review comments

@dguenther dguenther dguenther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgjohn @dguenther @dgca