Add react strict dom #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgjohn
reviewed
Nov 12, 2024
| @@ -0,0 +1,50 @@ | |||
| # React + TypeScript + Vite | |||
There was a problem hiding this comment.
At some point we will probably want to make it more personalized to the project but nbd for now
There was a problem hiding this comment.
Yeah, def. We should probably just start adding these things as backlog items to the project. I'll add one for Tackle Box README
cgjohn
reviewed
Nov 12, 2024
There was a problem hiding this comment.
Do we think we will want to bring back storybook as we get things setup?
cgjohn
approved these changes
Nov 12, 2024
|
@cgjohn R.e. src, let's keep it for now cause it might help us debug the web build when we set up Storybook. R.e. previewing, we can add them to the iOS app for now in the ui.tsx route. Def should come up with a better plan soon but I'll just merge this as is and we can come up with a better solution as we build out the components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swaps out React Native Web for
react-strict-domand adds a simple button example