-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: GHA testflight #4
Draft
jowparks
wants to merge
14
commits into
main
Choose a base branch
from
gha-testflight
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
gha-testflight
branch
from
March 25, 2024 22:00
bed67a6
to
f7e2b0f
Compare
jowparks
force-pushed
the
gha-testflight
branch
from
March 26, 2024 01:27
e433221
to
1204fd2
Compare
jowparks
force-pushed
the
gha-testflight
branch
from
March 26, 2024 01:28
1204fd2
to
a397f10
Compare
jowparks
force-pushed
the
gha-testflight
branch
from
March 26, 2024 19:20
c343f0d
to
d2e0e0c
Compare
jowparks
force-pushed
the
gha-testflight
branch
from
March 26, 2024 23:20
f52fec0
to
41453d2
Compare
jowparks
force-pushed
the
gha-testflight
branch
from
March 28, 2024 00:44
08710cf
to
2208eca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few options for uploading builds to testflight:
xctool
upload: Can use raw cli tools for building/archiving/uploading to testflight/App Store ConnectI attempted to use method 3, here is the journey (which is slightly incomplete).
Few hurdles when trying to get GHA running testflight creation:
rustup target install
for all missing targets.pod install
- We need to run this command to get thexcworkspace
to be generated in themobile-app/ios
directory. This XCode object is needed for publishing the project. Themacos-latest
runners have a bug because they are running older versions ofXCode
, so I needed to patch thePodfile
after creation. Bug report here: [SDK 50] Pod install error: The Swift podExpoModulesCore
depends uponglog
, which does not define modules. expo/expo#25905 . I tried overcome this issue by usingmacos-13
runners, which succeed without the patch, but there is a bug in their filesystem that doesn't allow access of the runners to the generated files in the ios directory..mobileprovision
for uploading apps to app store. This profile needs to be able to upload to the app store, there is an explicit option for this when you go through the creation wizard on app store connect. I provisioned one viaApp Store Connect
, serialized to base64 viabase64 -i "/Users/.../AppStoreMobileAppProfile.mobileprovision" | pbcopy
and added as secret to github actions. See 1password for copy of dataExportOptionsAppStore
xcworkspace
fromexpo prebuild
which wants to autosign, when performing from cli you need to change settings in project to manual via Xcode... but we are autogeneratingios
dir with prebuild . Below is the error message generated from GHA run: