Add data facade utility #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgca
commented
Apr 12, 2024
Comment on lines
+11
to
+14
| 1. Define your interface and create handlers | ||
| 2. Create facade context and export `FacadeProvider` and `useFacade` | ||
| 3. Wrap your application with `FacadeProvider` | ||
| 4. Use `useFacade` hook to access the facade in your components |
There was a problem hiding this comment.
I wanna expand on this, but figured I'd keep it simple while I get feedback on the implementation.
jowparks
reviewed
Apr 15, 2024
| import { AccountsMethods } from "./types"; | ||
|
|
||
| const accounts = ["alice", "bob", "carol"]; | ||
|
|
There was a problem hiding this comment.
I am expecting that we have a handlers file per datasource? ie /accounts/mock.ts, /accounts/walletServer.ts, etc?
jowparks
reviewed
Apr 15, 2024
| import { createFacadeContext } from "data-facade"; | ||
| import { accountsHandlers } from "./accounts/handlers"; | ||
|
|
||
| const facadeContext = createFacadeContext(accountsHandlers); |
There was a problem hiding this comment.
This is importing the mock implementation, how will this look when we have multiple handlers for different systems? Will there be a conditional here based on a setting? I am imagining that a user might change data backend at any point. Will the backend change result in a account reset/chain reset? Will that have any impact on your representation here?
jowparks
approved these changes
Apr 15, 2024
dguenther
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
data-facadepackage so that we can define the API interface and its implementation in isolation from the React app, so that we can swap out data sources in the future while reducing the need to refactor the React components themselves.