Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[156] Do not install unittest-xml-reporting==1.14.0 (main) #157

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

FifthPotato
Copy link
Contributor

Needed for fixing tests.

@FifthPotato FifthPotato changed the title [156] Remove install of unittest-xml-reporting==1.14.0 [156] Remove install of unittest-xml-reporting==1.14.0 (main) Aug 15, 2024
@FifthPotato FifthPotato changed the title [156] Remove install of unittest-xml-reporting==1.14.0 (main) [156] Do not install unittest-xml-reporting==1.14.0 (main) Aug 15, 2024
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# it if tests are running / passing

@korydraughn
Copy link
Contributor

@FifthPotato Is this a cherry-pick of #159?

If yes, pound it.

@korydraughn
Copy link
Contributor

For future PRs, always include a statement about "cherry-picking" if that's what happened.

@FifthPotato
Copy link
Contributor Author

For future PRs, always include a statement about "cherry-picking" if that's what happened.

Octothorpe'd. And yeah, my bad, it was because I opened this one prior to the 4-3-stable one, so I did this one, then 4-3-stable, then tested 4-3-stable, then came back to this (all were the same change).

...So it's a cherry-pick of a cherry-pick, I guess?

@alanking alanking merged commit f569a9f into irods:main Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants