Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#148] Remove clang-runtime from build hook (main) #149

Merged
merged 1 commit into from
May 1, 2024
Merged

[#148] Remove clang-runtime from build hook (main) #149

merged 1 commit into from
May 1, 2024

Conversation

alanking
Copy link
Contributor

@alanking alanking commented May 1, 2024

Addresses #148

@alanking alanking requested a review from SwooshyCueb May 1, 2024 01:11
korydraughn
korydraughn approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@korydraughn korydraughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it

@alanking
[irods#148] Remove clang-runtime from build hook
320f2cd 
The plugin is built against libstdc++ on this branch.
@alanking alanking merged commit 8d7354f into irods:main May 1, 2024
1 of 2 checks passed
@alanking alanking deleted the 148.m branch May 1, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korydraughn korydraughn korydraughn approved these changes

@SwooshyCueb SwooshyCueb SwooshyCueb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanking @SwooshyCueb @korydraughn