[irods/irods#7531] bump irods version requirement and remove exact requirement (main) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwooshyCueb
force-pushed
the
verbump.main
branch
from
72892b2
to
10b0dbd
Compare
korydraughn
approved these changes
Mar 1, 2024
SwooshyCueb
force-pushed
the
verbump.main
branch
from
10b0dbd
to
0cb1ea0
Compare
|
#'d |
|
Before I merge this, I just want to ask... The minimum required CMake version on 4-3-stable is going to be higher than it is on main due to the use of the version ranges in that branch. I think that's okay, but just wanted to say it out loud before merging. Are we okay with that situation? |
|
I'm fine with it. We have 3.21 in our externals. |
|
That sounds fine. If we run into issues, we can always bump the cmake minimum version. |
|
Yep, sounds good. It is written. Mergin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In service of irods/irods#7531
Merge irods/irods#7535 before merging this.