Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#126] Always return RULE_ENGINE_CONTINUE from exec_rule (main) #127

Merged
merged 1 commit into from
Oct 20, 2023
Merged

[#126] Always return RULE_ENGINE_CONTINUE from exec_rule (main) #127

merged 1 commit into from
Oct 20, 2023

Conversation

korydraughn
Copy link
Contributor

Will test soon.

trel
trel reviewed Oct 20, 2023
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
alanking
alanking reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things that apparently do not matter for compilation(?)

Please notify when confirmed working

src/main.cpp Outdated Show resolved Hide resolved
src/main.cpp Outdated Show resolved Hide resolved
@korydraughn
Copy link
Contributor Author

Everything is in working order.

@korydraughn
Copy link
Contributor Author

I've confirmed that before this PR, the plugin did not allow subsequent plugins to process rules.

@trel
Copy link
Member

trel commented Oct 20, 2023

perfect, squash and ready for assimilation.

alanking
alanking approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@alanking alanking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let's get it in

@korydraughn
Copy link
Contributor Author

#'d

@alanking alanking merged commit 3af1314 into irods:main Oct 20, 2023
2 checks passed
@korydraughn korydraughn deleted the 126.m branch October 20, 2023 17:06
@korydraughn korydraughn mentioned this pull request May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trel trel trel left review comments

@alanking alanking alanking approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korydraughn @trel @alanking