Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General modernization #95

Open
phdavis1027 opened this issue Jun 8, 2022 · 1 comment
Open

General modernization #95

phdavis1027 opened this issue Jun 8, 2022 · 1 comment
Assignees
@SwooshyCueb @phdavis1027
Labels
enhancement

Comments

@phdavis1027
Copy link
Collaborator

More cpp-style or generally efficient implementations of:

  • timestamps
  • message string building
  • etc.
@SwooshyCueb SwooshyCueb self-assigned this Aug 31, 2022
@SwooshyCueb
Copy link
Member

A non-exaustive list of modernizations to be done (will edit to add more):

  • replace gethostname() with boost::asio::ip:host_name(), add error handling
  • replace rodsLog with irods::experimental::log
  • use std::chrono for timestamps

@SwooshyCueb SwooshyCueb mentioned this issue Sep 7, 2022
Merged
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@phdavis1027 @SwooshyCueb
[irods#42,irods#73,irods#95,irods#102] Refactor to use nlohmann-json …
a59af5d 
…and qpid-cpp

Also, complete clang-tidy and clang-format refactor
Also also, removed of json wrapper tokens

Co-authored-by: Markus Kitsinger (SwooshyCueb) <[email protected]>
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] Use std::chrono for timestamps
9619976
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] Migrate from rodsLog to irods::experimental::log
55d25cd
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Log proton errors
b4fa32f
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Specify message content type
0ba96c9
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] use boost to get hostname
98d69fc
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] Refactor configuration loading
d60e395
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] migrate to std::regex, cache optimized regex
41ea8f0
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] migrate log path to std::filesystem::path
3c97674
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Set AMQP message creation timestamp
864e780
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Add unit test for conditional base64 encode
07f9b3e
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@phdavis1027 @SwooshyCueb
[irods#42,irods#73,irods#95,irods#102] Refactor to use nlohmann-json …
8573b01 
…and qpid-cpp

Also, complete clang-tidy and clang-format refactor
Also also, removed of json wrapper tokens

Co-authored-by: Markus Kitsinger (SwooshyCueb) <[email protected]>
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] Use std::chrono for timestamps
6e64938
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] Migrate from rodsLog to irods::experimental::log
36f4014
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Log proton errors
45841fc
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Specify message content type
1c6fd85
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] use boost to get hostname
e892a2e
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] Refactor configuration loading
1a09ffb
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] migrate to std::regex, cache optimized regex
9d5af71
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#95] migrate log path to std::filesystem::path
9d87259
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Set AMQP message creation timestamp
cc3b184
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 7, 2022
@SwooshyCueb
[irods#73,irods#95] Add unit test for conditional base64 encode
4069fc9
alanking pushed a commit that referenced this issue Nov 7, 2022
@phdavis1027 @SwooshyCueb @alanking
[#42,#73,#95,#102] Refactor to use nlohmann-json and qpid-cpp
f0de03e 
Also, complete clang-tidy and clang-format refactor
Also also, removed of json wrapper tokens

Co-authored-by: Markus Kitsinger (SwooshyCueb) <[email protected]>
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#95] Use std::chrono for timestamps
3a64a7a
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#95] Migrate from rodsLog to irods::experimental::log
4b03006
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#73,#95] Log proton errors
2b3a398
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#73,#95] Specify message content type
f70b990
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#95] use boost to get hostname
fda33d0
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#95] Refactor configuration loading
6ce6e5a
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#95] migrate to std::regex, cache optimized regex
19744bc
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#95] migrate log path to std::filesystem::path
443b8ee
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#73,#95] Set AMQP message creation timestamp
ffc2027
alanking pushed a commit that referenced this issue Nov 7, 2022
@SwooshyCueb @alanking
[#73,#95] Add unit test for conditional base64 encode
02d6c6d
SwooshyCueb added a commit to SwooshyCueb/irods_rule_engine_plugin_audit_amqp that referenced this issue Nov 28, 2022
@SwooshyCueb
[irods#73,irods#95] Fix unit test compilation
f956794
alanking pushed a commit that referenced this issue Nov 29, 2022
@SwooshyCueb @alanking
[#73,#95] Fix unit test compilation
18f0c41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SwooshyCueb SwooshyCueb

@phdavis1027 phdavis1027

Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
3 participants
@SwooshyCueb @alanking @phdavis1027