[42,73,102,104,110] Modernization and refactoring #105

SwooshyCueb · 2022-08-31T23:52:55Z

Addresses #42
Addresses #73
Addresses #102
Addresses #104
Addresses #110
In service of #95
In service of #103
Supersedes #96
Supersedes #97

This PR has a lot:

Fix for the RPM transaction check error (RPM package conflicts #104)
A little cleanup of CMakeLists.txt
Use of IrodsRunpathDefaults in CMakeLists.txt
Refactor to use nlohmann-json (replace use of jansson library with json library #42)
Refactor to use qpid-proton's C++ API (Replace use of deprecated functionality #73)
Removal of json wrapper tokens (Remove __BEGIN_JSON__/__END_JSON__ tokens #102)
std::chrono timestamp retrieval (in service of General modernization #95)
Unstringified, @timestamp-keyed milliseconds-since-epoch timestamp (in service of Emit json with proper types. #103)
Unstringified pid in emitted json (in service of Emit json with proper types. #103)
Migration from rodsLog to irods::experimental::log (in service of General modernization #95)
Removed unused amqp_options configuration setting (Remove 'amqp_options' #110)
Content type and creation timestamp in AMQP message metadata
hostname from boost (in service of General modernization #95)
better handling of default configuration
Reformat to our new clang-format and clang-tidy configuration
Migration from boost::regex to std::regex (in service of General modernization #95)
Migration to std::filesystem::path for test_mode log (in service of General modernization #95)
Removes old stomp-based python tests

trel · 2022-09-01T13:39:56Z

if this confirms the new qpid-proton packages are good-to-go, i'll get them pushed to packages.irods.org

korydraughn · 2022-09-01T21:09:32Z

Let's avoid adding the clang-format/tidy files to other projects until we figure out the reusable github workflows. I should have something ready regarding that soon.

.clang-format

libirods_rule_engine_plugin-audit_amqp.cpp

korydraughn

So much better. I like the utc_clock reference.

libirods_rule_engine_plugin-audit_amqp.cpp

korydraughn · 2022-09-09T14:02:46Z

Let's replace the use of "Resolves" word in the first comment of this PR so that the issues aren't automatically closed.

alanking

Looking real good

libirods_rule_engine_plugin-audit_amqp.cpp

SwooshyCueb · 2022-09-20T18:39:59Z

Note to self:
add a tick to "maximum oversquash" on the whiteboard

libirods_rule_engine_plugin-audit_amqp.cpp

- Add new platforms to build and test hooks - Remove jansson from build hook - Bump qpid-proton version in build hook Co-authored-by: Markus Kitsinger (SwooshyCueb) <[email protected]>

SwooshyCueb · 2022-11-07T17:48:23Z

Fixed the missing #, and added a change I forgot to include in the last commit (postinst script). Should be ready for merge now.
Running tests to find the failing unixfilesystem test, will open an issue for it once I find it

korydraughn · 2022-11-07T18:36:52Z

Don't forget to update/close the issues. Ping @alanking if you need a checkbox checked.

SwooshyCueb commented Sep 6, 2022

View reviewed changes

.clang-format Outdated Show resolved Hide resolved

SwooshyCueb commented Sep 6, 2022

View reviewed changes

libirods_rule_engine_plugin-audit_amqp.cpp Outdated Show resolved Hide resolved

SwooshyCueb force-pushed the refactor.main branch 5 times, most recently from af566f5 to 9cdf07a Compare September 7, 2022 23:29

SwooshyCueb changed the title ~~[WIP] [42,73,102,104] Modernization and refactoring~~ [WIP] [42,73,100,102,104] Modernization and refactoring Sep 7, 2022

SwooshyCueb force-pushed the refactor.main branch from 9cdf07a to 7dd277c Compare September 7, 2022 23:32

SwooshyCueb commented Sep 7, 2022

View reviewed changes

libirods_rule_engine_plugin-audit_amqp.cpp Outdated Show resolved Hide resolved

korydraughn requested changes Sep 9, 2022

View reviewed changes

SwooshyCueb force-pushed the refactor.main branch 3 times, most recently from e54820b to 9285c64 Compare September 12, 2022 18:58

alanking reviewed Sep 13, 2022

View reviewed changes

libirods_rule_engine_plugin-audit_amqp.cpp Outdated Show resolved Hide resolved

libirods_rule_engine_plugin-audit_amqp.cpp Outdated Show resolved Hide resolved

libirods_rule_engine_plugin-audit_amqp.cpp Outdated Show resolved Hide resolved

SwooshyCueb force-pushed the refactor.main branch 7 times, most recently from 6ec0387 to a205199 Compare September 13, 2022 20:41

korydraughn reviewed Sep 20, 2022

View reviewed changes

libirods_rule_engine_plugin-audit_amqp.cpp Outdated Show resolved Hide resolved

SwooshyCueb force-pushed the refactor.main branch from a205199 to fbd46c9 Compare September 20, 2022 20:22

SwooshyCueb commented Sep 20, 2022

View reviewed changes

libirods_rule_engine_plugin-audit_amqp.cpp Show resolved Hide resolved

SwooshyCueb force-pushed the refactor.main branch from fbd46c9 to d7b8726 Compare September 20, 2022 20:47

SwooshyCueb and others added 19 commits November 7, 2022 12:41

[irods#95] Use std::chrono for timestamps

6e64938

[irods#103] Change timestamp key to '@timestamp' and type to uint64_t

988ebac

[irods#103] do not stringify pid

c4259b8

[irods#95] Migrate from rodsLog to irods::experimental::log

36f4014

[irods#73,irods#95] Log proton errors

45841fc

[irods#110] Remove unused amqp_options configuration entry

142afae

[irods#73,irods#95] Specify message content type

1c6fd85

[irods#95] use boost to get hostname

e892a2e

[irods#95] Refactor configuration loading

1a09ffb

[irods/irods#6437] Add support for new platforms

0ea424a

- Add new platforms to build and test hooks - Remove jansson from build hook - Bump qpid-proton version in build hook Co-authored-by: Markus Kitsinger (SwooshyCueb) <[email protected]>

[irods#95] migrate to std::regex, cache optimized regex

9d5af71

[irods#95] migrate log path to std::filesystem::path

9d87259

[irods#73,irods#95] Set AMQP message creation timestamp

cc3b184

[irods#28] Update README.md

7726553

[irods#28] Touch up CMakeLists.txt

d479d4c

[irods#28] Slight repo reorganization

70d9469

[irods#28] More repo reorganization

651c768

[irods#73,irods#95] Add unit test for conditional base64 encode

4069fc9

[irods#28] Update python tests

90e1778

SwooshyCueb force-pushed the refactor.main branch from 2b06616 to fd3a799 Compare November 7, 2022 17:41

[irods#28] Remove stomp-based test suite

d596bef

SwooshyCueb force-pushed the refactor.main branch from fd3a799 to d596bef Compare November 7, 2022 17:44

alanking approved these changes Nov 7, 2022

View reviewed changes

alanking merged commit 626ae1f into irods:main Nov 7, 2022

This was referenced Nov 28, 2022

[#73,#95] Fix unit test compilation #112

Merged

replace jansson with nlohmann::json (master) #48

Closed

[WIP] Refactor, stage 2 #113

Draft

trel mentioned this pull request Jun 11, 2023

plugin behaviour when rabbitMQ target is down #108

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[42,73,102,104,110] Modernization and refactoring #105

[42,73,102,104,110] Modernization and refactoring #105

SwooshyCueb commented Aug 31, 2022 •

edited

Loading

trel commented Sep 1, 2022

korydraughn commented Sep 1, 2022

korydraughn left a comment

korydraughn commented Sep 9, 2022

alanking left a comment

SwooshyCueb commented Sep 20, 2022 •

edited

Loading

SwooshyCueb commented Nov 7, 2022 •

edited

Loading

korydraughn commented Nov 7, 2022

[42,73,102,104,110] Modernization and refactoring #105

[42,73,102,104,110] Modernization and refactoring #105

Conversation

SwooshyCueb commented Aug 31, 2022 • edited Loading

trel commented Sep 1, 2022

korydraughn commented Sep 1, 2022

korydraughn left a comment

Choose a reason for hiding this comment

korydraughn commented Sep 9, 2022

alanking left a comment

Choose a reason for hiding this comment

SwooshyCueb commented Sep 20, 2022 • edited Loading

SwooshyCueb commented Nov 7, 2022 • edited Loading

korydraughn commented Nov 7, 2022

SwooshyCueb commented Aug 31, 2022 •

edited

Loading

SwooshyCueb commented Sep 20, 2022 •

edited

Loading

SwooshyCueb commented Nov 7, 2022 •

edited

Loading