Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage Tickets (main) #152

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Conversation

ganning127
Copy link
Contributor

@ganning127 ganning127 commented Jun 15, 2023

  • View tickets
  • Sort tickets
  • Filter for tickets
  • Add pagination for large amounts of tickets
  • Add base argument to parseInt to fix codeacy error
  • Add expandable rows on each ticket to view more ticket information
  • If modifyTime == createTime, show no modification made
  • PR is waiting on support for ticket generation (/ticket)

image

@trel
Copy link
Member

trel commented Jun 18, 2023

This PR shouldn't include the year update commit(s). Want to keep your branches/PRs separate and independent. Easier to reason about and easier to merge as they won't conflict with themselves.

@trel
Copy link
Member

trel commented Jun 18, 2023

more columns available... should discuss what we want to show...

$ iquest attrs | grep TICKET
TICKET_ID
TICKET_STRING
TICKET_TYPE
TICKET_USER_ID
TICKET_OBJECT_ID
TICKET_OBJECT_TYPE
TICKET_USES_LIMIT
TICKET_USES_COUNT
TICKET_WRITE_FILE_COUNT
TICKET_WRITE_FILE_LIMIT
TICKET_WRITE_BYTE_COUNT
TICKET_WRITE_BYTE_LIMIT
TICKET_EXPIRY
TICKET_CREATE_TIME
TICKET_MODIFY_TIME
TICKET_ALLOWED_HOST_TICKET_ID
TICKET_ALLOWED_HOST
TICKET_ALLOWED_USER_TICKET_ID
TICKET_ALLOWED_USER_NAME
TICKET_ALLOWED_GROUP_TICKET_ID
TICKET_ALLOWED_GROUP_NAME
TICKET_DATA_NAME
TICKET_DATA_COLL_NAME
TICKET_COLL_NAME
TICKET_OWNER_NAME
TICKET_OWNER_ZONE

@ganning127
Copy link
Contributor Author

Just added these data columns into the table:

TICKET_ID = 0
TICKET_STRING = 1
TICKET_TYPE = 2
TICKET_USER_ID = 3
TICKET_OBJECT_ID = 4
TICKET_OBJECT_TYPE = 5
TICKET_USES_LIMIT = 6
TICKET_USES_COUNT = 7
TICKET_WRITE_FILE_COUNT = 8
TICKET_WRITE_FILE_LIMIT = 9
TICKET_WRITE_BYTE_COUNT = 10
TICKET_WRITE_BYTE_LIMIT = 11
TICKET_EXPIRY = 12
TICKET_CREATE_TIME = 13
TICKET_MODIFY_TIME = 14
TICKET_DATA_NAME = 15
TICKET_DATA_COLL_NAME = 16
TICKET_OWNER_NAME = 17
TICKET_OWNER_ZONE = 18

All numbers are the data's index's in the code (since its a list). The other columns (TICKET_ID, TICKET_ALLOWED_USER_TICKET_ID, TICKET_ALLOWED_USER_NAME, TICKET_ALLOWED_HOST_TICKET_ID, TICKET_ALLOWED_HOST, TICKET_ALLOWED_GROUP_TICKET_ID, TICKET_ALLOWED_GROUP_NAME, TICKET_COLL_NAME) are giving me issues and won't let me add them.

@ganning127 ganning127 marked this pull request as ready for review June 19, 2023 19:02
@ganning127
Copy link
Contributor Author

not sure if you get notifications for when this PR is marked as "ready for review", but it's ready for review now 🙃

@ganning127 ganning127 changed the title Manage Tickets Manage Tickets (main) Jun 22, 2023
@trel
Copy link
Member

trel commented Jul 8, 2023

this PR on hold - awaiting smarter /ticket endpoint in the REST API itself.

@trel
Copy link
Member

trel commented Aug 10, 2024

This PR will need to be updated for the HTTP API.

HTTP API 0.3.0 only supports create and remove. No update.

@trel trel marked this pull request as draft August 10, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants