-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump up mods.irisnet.org/modules/service to cosmos-sdk v0.50.10 #452
Changes from all commits
a10d213
cfb87f3
9d8b10c
2a39eaf
34cd5a7
77215d5
8b34544
ccc17ef
3fadced
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,8 @@ package service | |
import ( | ||
"cosmossdk.io/core/appmodule" | ||
"cosmossdk.io/depinject" | ||
store "cosmossdk.io/store/types" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Codebase verification Store import path needs to be updated across multiple modules The verification reveals inconsistent usage of store import paths across the codebase. While some files have been updated to use
🔗 Analysis chainVerify consistent usage of new store import path across the codebase The update of the store import path to Let me try the verification again with the correct command to check store imports. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for any remaining old store import paths
# Expected: No occurrences of the old import path should be found
echo "Checking for old store import paths..."
rg "github.com/cosmos/cosmos-sdk/store/types" --type go
echo "Verifying new store import usage..."
rg "cosmossdk.io/store/types" --type go
Length of output: 11002 Script: #!/bin/bash
# Description: Check for any remaining old store import paths and new store import paths
echo "Checking for old store import paths..."
rg '"github.com/cosmos/cosmos-sdk/store/types"' --type go
echo -e "\nChecking for new store import usage..."
rg '"cosmossdk.io/store/types"' --type go
Length of output: 2810 |
||
"github.com/cosmos/cosmos-sdk/codec" | ||
store "github.com/cosmos/cosmos-sdk/store/types" | ||
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" | ||
govtypes "github.com/cosmos/cosmos-sdk/x/gov/types" | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,188 +1,204 @@ | ||
module mods.irisnet.org/modules/service | ||
|
||
go 1.19 | ||
go 1.21 | ||
|
||
require ( | ||
cosmossdk.io/api v0.3.1 | ||
cosmossdk.io/core v0.5.1 | ||
cosmossdk.io/depinject v1.0.0-alpha.4 | ||
cosmossdk.io/api v0.7.5 | ||
cosmossdk.io/core v0.11.1 | ||
cosmossdk.io/depinject v1.0.0 | ||
cosmossdk.io/errors v1.0.1 | ||
github.com/cometbft/cometbft v0.37.4 | ||
github.com/cosmos/cosmos-proto v1.0.0-beta.4 | ||
github.com/cosmos/cosmos-sdk v0.47.9 | ||
github.com/cosmos/gogoproto v1.4.10 | ||
github.com/golang/protobuf v1.5.3 | ||
cosmossdk.io/log v1.4.1 | ||
cosmossdk.io/math v1.3.0 | ||
cosmossdk.io/store v1.1.1 | ||
cosmossdk.io/x/evidence v0.1.1 | ||
cosmossdk.io/x/feegrant v0.1.1 | ||
cosmossdk.io/x/upgrade v0.1.4 | ||
github.com/cometbft/cometbft v0.38.12 | ||
github.com/cosmos/cosmos-proto v1.0.0-beta.5 | ||
github.com/cosmos/cosmos-sdk v0.50.10 | ||
Comment on lines
+16
to
+18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Security Update Required: Update CometBFT and Cosmos SDK Based on the security analysis:
Please update to the following secure versions:
|
||
github.com/cosmos/gogoproto v1.7.0 | ||
github.com/golang/protobuf v1.5.4 | ||
github.com/grpc-ecosystem/grpc-gateway v1.16.0 | ||
github.com/spf13/cobra v1.6.1 | ||
github.com/spf13/cobra v1.8.1 | ||
github.com/spf13/pflag v1.0.5 | ||
github.com/stretchr/testify v1.8.4 | ||
github.com/stretchr/testify v1.9.0 | ||
github.com/tidwall/gjson v1.14.4 | ||
github.com/xeipuuv/gojsonschema v1.2.0 | ||
google.golang.org/genproto/googleapis/api v0.0.0-20231212172506-995d672761c0 | ||
google.golang.org/grpc v1.60.1 | ||
google.golang.org/protobuf v1.32.0 | ||
google.golang.org/genproto/googleapis/api v0.0.0-20240318140521-94a12d6c2237 | ||
google.golang.org/grpc v1.64.1 | ||
google.golang.org/protobuf v1.34.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Security Update Required: Update Protocol Buffers The current version of Update to v1.33.0 or later to address this security issue. |
||
gopkg.in/yaml.v2 v2.4.0 | ||
mods.irisnet.org/api v0.0.0-20240628054110-4cb043e0238a | ||
mods.irisnet.org/simapp v0.0.0-20240628054110-4cb043e0238a | ||
) | ||
|
||
require ( | ||
cloud.google.com/go v0.111.0 // indirect | ||
cloud.google.com/go/compute v1.23.3 // indirect | ||
cloud.google.com/go/compute/metadata v0.2.3 // indirect | ||
cloud.google.com/go/iam v1.1.5 // indirect | ||
cloud.google.com/go/storage v1.30.1 // indirect | ||
cosmossdk.io/log v1.3.1 // indirect | ||
cosmossdk.io/math v1.2.0 // indirect | ||
cosmossdk.io/tools/rosetta v0.2.1 // indirect | ||
cloud.google.com/go v0.112.1 // indirect | ||
cloud.google.com/go/compute/metadata v0.3.0 // indirect | ||
cloud.google.com/go/iam v1.1.6 // indirect | ||
cloud.google.com/go/storage v1.38.0 // indirect | ||
cosmossdk.io/collections v0.4.0 // indirect | ||
cosmossdk.io/x/tx v0.13.5 // indirect | ||
filippo.io/edwards25519 v1.0.0 // indirect | ||
github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect | ||
github.com/99designs/keyring v1.2.1 // indirect | ||
github.com/ChainSafe/go-schnorrkel v1.0.0 // indirect | ||
github.com/armon/go-metrics v0.4.1 // indirect | ||
github.com/aws/aws-sdk-go v1.44.203 // indirect | ||
github.com/DataDog/datadog-go v3.2.0+incompatible // indirect | ||
github.com/DataDog/zstd v1.5.5 // indirect | ||
github.com/aws/aws-sdk-go v1.44.224 // indirect | ||
github.com/beorn7/perks v1.0.1 // indirect | ||
github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d // indirect | ||
github.com/bgentry/speakeasy v0.1.1-0.20220910012023-760eaf8b6816 // indirect | ||
github.com/btcsuite/btcd/btcec/v2 v2.3.2 // indirect | ||
github.com/bits-and-blooms/bitset v1.8.0 // indirect | ||
github.com/btcsuite/btcd/btcec/v2 v2.3.4 // indirect | ||
github.com/cenkalti/backoff/v4 v4.1.3 // indirect | ||
github.com/cespare/xxhash v1.1.0 // indirect | ||
github.com/cespare/xxhash/v2 v2.2.0 // indirect | ||
github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
github.com/chzyer/readline v1.5.1 // indirect | ||
github.com/cockroachdb/apd/v2 v2.0.2 // indirect | ||
github.com/cockroachdb/errors v1.10.0 // indirect | ||
github.com/cockroachdb/errors v1.11.3 // indirect | ||
github.com/cockroachdb/fifo v0.0.0-20240606204812-0bbfbd93a7ce // indirect | ||
github.com/cockroachdb/logtags v0.0.0-20230118201751-21c54148d20b // indirect | ||
github.com/cockroachdb/pebble v1.1.1 // indirect | ||
github.com/cockroachdb/redact v1.1.5 // indirect | ||
github.com/coinbase/rosetta-sdk-go/types v1.0.0 // indirect | ||
github.com/cometbft/cometbft-db v0.7.0 // indirect | ||
github.com/confio/ics23/go v0.9.0 // indirect | ||
github.com/cockroachdb/tokenbucket v0.0.0-20230807174530-cc333fc44b06 // indirect | ||
github.com/cometbft/cometbft-db v0.11.0 // indirect | ||
github.com/cosmos/btcutil v1.0.5 // indirect | ||
github.com/cosmos/cosmos-db v1.0.2 // indirect | ||
github.com/cosmos/go-bip39 v1.0.0 // indirect | ||
github.com/cosmos/gogogateway v1.2.0 // indirect | ||
github.com/cosmos/iavl v0.20.1 // indirect | ||
github.com/cosmos/ledger-cosmos-go v0.12.4 // indirect | ||
github.com/cosmos/rosetta-sdk-go v0.10.0 // indirect | ||
github.com/creachadair/taskgroup v0.3.2 // indirect | ||
github.com/cosmos/iavl v1.2.0 // indirect | ||
github.com/cosmos/ics23/go v0.11.0 // indirect | ||
github.com/cosmos/ledger-cosmos-go v0.13.3 // indirect | ||
github.com/danieljoos/wincred v1.1.2 // indirect | ||
github.com/davecgh/go-spew v1.1.1 // indirect | ||
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.1.0 // indirect | ||
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect | ||
github.com/decred/dcrd/dcrec/secp256k1/v4 v4.2.0 // indirect | ||
github.com/desertbit/timer v0.0.0-20180107155436-c41aec40b27f // indirect | ||
github.com/dgraph-io/badger/v2 v2.2007.4 // indirect | ||
github.com/dgraph-io/ristretto v0.1.1 // indirect | ||
github.com/dgryski/go-farm v0.0.0-20200201041132-a6ae2369ad13 // indirect | ||
github.com/dustin/go-humanize v1.0.1 // indirect | ||
github.com/dvsekhvalnov/jose2go v1.6.0 // indirect | ||
github.com/felixge/httpsnoop v1.0.2 // indirect | ||
github.com/fsnotify/fsnotify v1.6.0 // indirect | ||
github.com/getsentry/sentry-go v0.23.0 // indirect | ||
github.com/emicklei/dot v1.6.1 // indirect | ||
github.com/fatih/color v1.15.0 // indirect | ||
github.com/felixge/httpsnoop v1.0.4 // indirect | ||
github.com/fsnotify/fsnotify v1.7.0 // indirect | ||
github.com/getsentry/sentry-go v0.27.0 // indirect | ||
github.com/go-kit/kit v0.12.0 // indirect | ||
github.com/go-kit/log v0.2.1 // indirect | ||
github.com/go-logfmt/logfmt v0.5.1 // indirect | ||
github.com/go-logr/logr v1.2.4 // indirect | ||
github.com/go-logfmt/logfmt v0.6.0 // indirect | ||
github.com/go-logr/logr v1.4.1 // indirect | ||
github.com/go-logr/stdr v1.2.2 // indirect | ||
github.com/godbus/dbus v0.0.0-20190726142602-4481cbc300e2 // indirect | ||
github.com/gogo/googleapis v1.4.1 // indirect | ||
github.com/gogo/protobuf v1.3.2 // indirect | ||
github.com/golang/glog v1.1.2 // indirect | ||
github.com/golang/glog v1.2.0 // indirect | ||
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect | ||
github.com/golang/mock v1.6.0 // indirect | ||
github.com/golang/snappy v0.0.4 // indirect | ||
github.com/google/btree v1.1.2 // indirect | ||
github.com/google/go-cmp v0.6.0 // indirect | ||
github.com/google/orderedcode v0.0.1 // indirect | ||
github.com/google/s2a-go v0.1.7 // indirect | ||
github.com/google/uuid v1.4.0 // indirect | ||
github.com/google/uuid v1.6.0 // indirect | ||
github.com/googleapis/enterprise-certificate-proxy v0.3.2 // indirect | ||
github.com/googleapis/gax-go/v2 v2.12.0 // indirect | ||
github.com/googleapis/gax-go/v2 v2.12.3 // indirect | ||
github.com/gorilla/handlers v1.5.1 // indirect | ||
github.com/gorilla/mux v1.8.0 // indirect | ||
github.com/gorilla/websocket v1.5.0 // indirect | ||
github.com/grpc-ecosystem/go-grpc-middleware v1.3.0 // indirect | ||
github.com/gorilla/websocket v1.5.3 // indirect | ||
github.com/grpc-ecosystem/go-grpc-middleware v1.4.0 // indirect | ||
github.com/gsterjov/go-libsecret v0.0.0-20161001094733-a6f4afe4910c // indirect | ||
github.com/gtank/merlin v0.1.1 // indirect | ||
github.com/gtank/ristretto255 v0.1.2 // indirect | ||
github.com/hashicorp/go-cleanhttp v0.5.2 // indirect | ||
github.com/hashicorp/go-getter v1.7.1 // indirect | ||
github.com/hashicorp/go-getter v1.7.4 // indirect | ||
github.com/hashicorp/go-hclog v1.5.0 // indirect | ||
github.com/hashicorp/go-immutable-radix v1.3.1 // indirect | ||
github.com/hashicorp/go-metrics v0.5.3 // indirect | ||
github.com/hashicorp/go-plugin v1.5.2 // indirect | ||
github.com/hashicorp/go-safetemp v1.0.0 // indirect | ||
github.com/hashicorp/go-version v1.6.0 // indirect | ||
github.com/hashicorp/golang-lru v0.5.5-0.20210104140557-80c98217689d // indirect | ||
github.com/hashicorp/golang-lru v1.0.2 // indirect | ||
github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect | ||
github.com/hashicorp/hcl v1.0.0 // indirect | ||
github.com/hashicorp/yamux v0.1.1 // indirect | ||
github.com/hdevalence/ed25519consensus v0.1.0 // indirect | ||
github.com/huandu/skiplist v1.2.0 // indirect | ||
github.com/iancoleman/strcase v0.3.0 // indirect | ||
github.com/improbable-eng/grpc-web v0.15.0 // indirect | ||
github.com/inconshreveable/mousetrap v1.0.1 // indirect | ||
github.com/inconshreveable/mousetrap v1.1.0 // indirect | ||
github.com/jmespath/go-jmespath v0.4.0 // indirect | ||
github.com/jmhodges/levigo v1.0.0 // indirect | ||
github.com/klauspost/compress v1.16.7 // indirect | ||
github.com/klauspost/compress v1.17.9 // indirect | ||
github.com/kr/pretty v0.3.1 // indirect | ||
github.com/kr/text v0.2.0 // indirect | ||
github.com/lib/pq v1.10.7 // indirect | ||
github.com/libp2p/go-buffer-pool v0.1.0 // indirect | ||
github.com/magiconair/properties v1.8.6 // indirect | ||
github.com/linxGnu/grocksdb v1.8.14 // indirect | ||
github.com/magiconair/properties v1.8.7 // indirect | ||
github.com/manifoldco/promptui v0.9.0 // indirect | ||
github.com/mattn/go-colorable v0.1.13 // indirect | ||
github.com/mattn/go-isatty v0.0.20 // indirect | ||
github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect | ||
github.com/mimoo/StrobeGo v0.0.0-20210601165009-122bf33a46e0 // indirect | ||
github.com/minio/highwayhash v1.0.2 // indirect | ||
github.com/mitchellh/go-homedir v1.1.0 // indirect | ||
github.com/mitchellh/go-testing-interface v1.14.1 // indirect | ||
github.com/mitchellh/mapstructure v1.5.0 // indirect | ||
github.com/mtibben/percent v0.2.1 // indirect | ||
github.com/pelletier/go-toml v1.9.5 // indirect | ||
github.com/pelletier/go-toml/v2 v2.0.7 // indirect | ||
github.com/petermattis/goid v0.0.0-20230317030725-371a4b8eda08 // indirect | ||
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||
github.com/oasisprotocol/curve25519-voi v0.0.0-20230904125328-1f23a7beb09a // indirect | ||
github.com/oklog/run v1.1.0 // indirect | ||
github.com/pelletier/go-toml/v2 v2.2.2 // indirect | ||
github.com/petermattis/goid v0.0.0-20231207134359-e60b3f734c67 // indirect | ||
github.com/pkg/errors v0.9.1 // indirect | ||
github.com/pmezard/go-difflib v1.0.0 // indirect | ||
github.com/prometheus/client_golang v1.14.0 // indirect | ||
github.com/prometheus/client_model v0.3.0 // indirect | ||
github.com/prometheus/common v0.42.0 // indirect | ||
github.com/prometheus/procfs v0.9.0 // indirect | ||
github.com/rakyll/statik v0.1.7 // indirect | ||
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect | ||
github.com/prometheus/client_golang v1.20.1 // indirect | ||
github.com/prometheus/client_model v0.6.1 // indirect | ||
github.com/prometheus/common v0.55.0 // indirect | ||
github.com/prometheus/procfs v0.15.1 // indirect | ||
github.com/rcrowley/go-metrics v0.0.0-20201227073835-cf1acfcdf475 // indirect | ||
github.com/rogpeppe/go-internal v1.11.0 // indirect | ||
github.com/rs/cors v1.8.2 // indirect | ||
github.com/rs/zerolog v1.32.0 // indirect | ||
github.com/rogpeppe/go-internal v1.12.0 // indirect | ||
github.com/rs/cors v1.11.1 // indirect | ||
github.com/rs/zerolog v1.33.0 // indirect | ||
github.com/sagikazarmark/locafero v0.4.0 // indirect | ||
github.com/sagikazarmark/slog-shim v0.1.0 // indirect | ||
github.com/sasha-s/go-deadlock v0.3.1 // indirect | ||
github.com/spf13/afero v1.9.2 // indirect | ||
github.com/spf13/cast v1.5.0 // indirect | ||
github.com/spf13/jwalterweatherman v1.1.0 // indirect | ||
github.com/spf13/viper v1.14.0 // indirect | ||
github.com/subosito/gotenv v1.4.1 // indirect | ||
github.com/sourcegraph/conc v0.3.0 // indirect | ||
github.com/spf13/afero v1.11.0 // indirect | ||
github.com/spf13/cast v1.6.0 // indirect | ||
github.com/spf13/viper v1.19.0 // indirect | ||
github.com/subosito/gotenv v1.6.0 // indirect | ||
github.com/syndtr/goleveldb v1.0.1-0.20220721030215-126854af5e6d // indirect | ||
github.com/tecbot/gorocksdb v0.0.0-20191217155057-f0fad39f321c // indirect | ||
github.com/tendermint/go-amino v0.16.0 // indirect | ||
github.com/tidwall/btree v1.6.0 // indirect | ||
github.com/tidwall/btree v1.7.0 // indirect | ||
github.com/tidwall/match v1.1.1 // indirect | ||
github.com/tidwall/pretty v1.2.0 // indirect | ||
github.com/ulikunitz/xz v0.5.11 // indirect | ||
github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f // indirect | ||
github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415 // indirect | ||
github.com/zondax/hid v0.9.2 // indirect | ||
github.com/zondax/ledger-go v0.14.3 // indirect | ||
go.etcd.io/bbolt v1.3.7 // indirect | ||
go.etcd.io/bbolt v1.3.10 // indirect | ||
go.opencensus.io v0.24.0 // indirect | ||
go.opentelemetry.io/otel v1.19.0 // indirect | ||
go.opentelemetry.io/otel/metric v1.19.0 // indirect | ||
go.opentelemetry.io/otel/trace v1.19.0 // indirect | ||
golang.org/x/crypto v0.16.0 // indirect | ||
golang.org/x/exp v0.0.0-20230711153332-06a737ee72cb // indirect | ||
golang.org/x/net v0.19.0 // indirect | ||
golang.org/x/oauth2 v0.13.0 // indirect | ||
golang.org/x/sync v0.4.0 // indirect | ||
golang.org/x/sys v0.16.0 // indirect | ||
golang.org/x/term v0.15.0 // indirect | ||
golang.org/x/text v0.14.0 // indirect | ||
google.golang.org/api v0.149.0 // indirect | ||
google.golang.org/appengine v1.6.8 // indirect | ||
google.golang.org/genproto v0.0.0-20240102182953-50ed04b92917 // indirect | ||
google.golang.org/genproto/googleapis/rpc v0.0.0-20240108191215-35c7eff3a6b1 // indirect | ||
go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.49.0 // indirect | ||
go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.49.0 // indirect | ||
go.opentelemetry.io/otel v1.24.0 // indirect | ||
go.opentelemetry.io/otel/metric v1.24.0 // indirect | ||
go.opentelemetry.io/otel/trace v1.24.0 // indirect | ||
go.uber.org/multierr v1.10.0 // indirect | ||
golang.org/x/crypto v0.26.0 // indirect | ||
golang.org/x/exp v0.0.0-20240404231335-c0f41cb1a7a0 // indirect | ||
golang.org/x/net v0.28.0 // indirect | ||
golang.org/x/oauth2 v0.21.0 // indirect | ||
golang.org/x/sync v0.8.0 // indirect | ||
golang.org/x/sys v0.24.0 // indirect | ||
golang.org/x/term v0.23.0 // indirect | ||
golang.org/x/text v0.17.0 // indirect | ||
golang.org/x/time v0.5.0 // indirect | ||
google.golang.org/api v0.171.0 // indirect | ||
google.golang.org/genproto v0.0.0-20240227224415-6ceb2ff114de // indirect | ||
google.golang.org/genproto/googleapis/rpc v0.0.0-20240709173604-40e1e62336c5 // indirect | ||
gopkg.in/ini.v1 v1.67.0 // indirect | ||
gopkg.in/yaml.v3 v3.0.1 // indirect | ||
gotest.tools/v3 v3.5.1 // indirect | ||
nhooyr.io/websocket v1.8.6 // indirect | ||
pgregory.net/rapid v1.1.0 // indirect | ||
sigs.k8s.io/yaml v1.3.0 // indirect | ||
sigs.k8s.io/yaml v1.4.0 // indirect | ||
) | ||
|
||
replace ( | ||
|
@@ -196,4 +212,8 @@ replace ( | |
github.com/gin-gonic/gin => github.com/gin-gonic/gin v1.9.0 | ||
// Downgraded to avoid bugs in following commits which caused simulations to fail. | ||
github.com/syndtr/goleveldb => github.com/syndtr/goleveldb v1.0.1-0.20210819022825-2ae1ddf74ef7 | ||
|
||
// todo replace version | ||
mods.irisnet.org/api => ../../api | ||
mods.irisnet.org/simapp => ../../simapp | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Update required: EndBlockEvents still present in e2e tests
The migration from
EndBlockEvents
toFinalizeBlockEvents
is incomplete. While the change has been made in the main code (modules/service/client/utils/query.go
), there are several instances in e2e tests that still use the oldEndBlockEvents
:e2e/service/query.go
e2e/service/tx.go
e2e/oracle/tx.go
e2e/random/tx.go
e2e/random/query.go
These test files need to be updated to use
FinalizeBlockEvents
to maintain consistency with the ABCI++ interface changes.🔗 Analysis chain
LGTM: Correct adaptation to CometBFT's ABCI++ interface
The change from
EndBlockEvents
toFinalizeBlockEvents
correctly aligns with the breaking changes introduced in CometBFT's ABCI++ interface, where EndBlock has been replaced with FinalizeBlock.Let's verify that this change has been consistently applied across the codebase:
The previous search didn't show the relevant results. Let's try a more focused search to find all instances of block event handling in the codebase to verify the consistency of the changes.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 822
Script:
Length of output: 3639