-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add gov handler #421
Conversation
WalkthroughThe new Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GovModule as Governance Module
participant FarmModule as Farm Module
participant Keeper
participant Context as sdk.Context
User ->> GovModule: Submit Proposal
GovModule ->> FarmModule: Route Proposal to Farm Module
FarmModule ->> Keeper: Process Proposal
Keeper -->> FarmModule: Return Processing Result
FarmModule -->> GovModule: Notify Result
GovModule -->> User: Proposal Outcome
Poem
Tip AI model upgrade
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- modules/farm/handler.go (1 hunks)
Additional comments not posted (2)
modules/farm/handler.go (2)
13-25
: LGTM! But verify all necessary proposal types are handled.The code changes are approved.
However, ensure that all necessary proposal types are handled in the switch statement.
28-30
: LGTM! But verify the keeper function implementation.The code changes are approved.
However, ensure that
HandleCreateFarmProposal
in the keeper is implemented correctly.
Summary by CodeRabbit