Fix backend update racing problem with dpvs-agent and healthcheck. #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ched wrong vs-version from client
…ged adminstratively When healthcheck program updating the rs's weight, it should consider: * rs's weight may change adminstratively * rs availabilty may change due to the server is closed or crashed Healthcheck stores the original weight when it sends down notification in order to restore the rs's weight when it gets healthy later. The problem is original weight is syncd from dpvs periodically and not always up-to-date, which may result in incorrect weight update in healthcheck up notification. Signed-off-by: ywc689 <[email protected]>
Unfortunately, the CAS solution in the last commit is not effective for healthcheck process cannot maintain the correct previous weight value. Thus resource version is used instead, which should be passed to the lb api when the healthcheck try to update rs, and the api would reject the request if the resouce version is outdated. use vs version to resync target status when notification fails Signed-off-by: ywc689 <[email protected]>
- update config version finally in updateConfig and only when the backend config is in healthy state - fix notification resync fail problem caused by insufficient channel size - fix array index problem in function NewTargetFromStr Signed-off-by: ywc689 <[email protected]>
Signed-off-by: ywc689 <[email protected]>
…g. POST|PUT /vs/${ID}/rs, PUT /vs/${ID})
Healthcheck api /vs/${ID}/rs/health would not update local cache.
GET API /vs | /vs/${ID} response dpvs-agent local cache info default
and response dpvs running service detail with query param `healthcheck=true`
ywc689
added
the
pr/to-review-codes
…checkers Signed-off-by: ywc689 <[email protected]>
Signed-off-by: ywc689 <[email protected]>
you-looks-not-tasty
approved these changes
Apr 9, 2024
ywc689
added
pr/accepted
liuxuting
reviewed
May 17, 2024
| } | ||
|
|
||
| // if params.Snapshot != nil && *params.Snapshot { | ||
| // shareSnapshot.DumpTo(settings.LocalConfigFile(), h.logger) |
There was a problem hiding this comment.
why do you remove DumpTo? And how to generate cache file?
There was a problem hiding this comment.
The default value of snapshot is true, and the dpvs-healthcheck module has not been set snapshot to false.
healthcheck module makes heavily invoked to getVs(), which will generate a large number of cache files.
We will fix this issue in the next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.