Close IOPubThread._event_puller.socket

.github/workflows/ci.yml

@@ -38,6 +38,7 @@ jobs:
       - name: Install the Python dependencies
         run: |
           pip install .[test] codecov
+          pip install https://github.com/davidbrochart/jupyter_client/archive/async_stream.zip
 
       - name: Install matplotlib
         if: ${{ !startsWith(matrix.os, 'macos') && !startsWith(matrix.python-version, 'pypy') }}

.github/workflows/downstream.yml

@@ -68,4 +68,5 @@ jobs:
           git clone https://github.com/jupyter/jupyter_kernel_test.git
           cd jupyter_kernel_test
           pip install -e ".[test]"
+          pip install https://github.com/davidbrochart/jupyter_client/archive/async_stream.zip
           python test_ipykernel.py

ipykernel/iostream.py

@@ -190,6 +190,7 @@ def stop(self):
         # so after thread.join, this should be safe
         for event_pipe in self._event_pipes:
             event_pipe.close()
+        self._event_puller.socket.close()
 
     def close(self):
         if self.closed:

ipykernel/tests/test_io.py

@@ -4,6 +4,7 @@
 
 import pytest
 import zmq
+import zmq.asyncio
 from jupyter_client.session import Session
 
 from ipykernel.iostream import IOPubThread, OutStream
@@ -12,7 +13,7 @@
 def test_io_api():
     """Test that wrapped stdout has the same API as a normal TextIO object"""
     session = Session()
-    ctx = zmq.Context()
+    ctx = zmq.asyncio.Context()
     pub = ctx.socket(zmq.PUB)
     thread = IOPubThread(pub)
     thread.start()

ipykernel/zmqstream.py

@@ -27,5 +27,5 @@ async def recv_task(self, callback, copy):
     def send_multipart(self, msg_list, flags=0, copy=True, track=False, **kwargs):
         return self.socket.send_multipart(msg_list, copy=copy)
 
-    def flush(self, flag=None, limit = None):
+    def flush(self, flag=None, limit=None):
         pass