feat(mv3): ➕ Adding hash function to generate predict… (#1273)

feat(mv3): ➕ Adding hash function to generate predictable ids.

Signed-off-by: Nishant Arora <[email protected]>

add-on/src/lib/redirect-handler/blockOrObserve.ts

@@ -1,4 +1,5 @@
 import debug from 'debug'
+import { fastHashCode } from 'fast-hash-code'
 import browser from 'webextension-polyfill'
 import { CompanionState } from '../../types/companion.js'
 import { IFilter, IRegexFilter, RegexFilter } from './baseRegexFilter.js'
@@ -284,8 +285,10 @@ function saveAndGenerateRule (
   regexSubstitution: string,
   excludedInitiatorDomains: string[] = []
 ): browser.DeclarativeNetRequest.Rule {
-  // We need to generate a random ID for the rule.
-  const id = Math.floor(Math.random() * 29999)
+  // We need to generate a positive number as an id.
+  const id = fastHashCode(`${regexFilter}:${regexSubstitution}:${excludedInitiatorDomains.join(':')}`, {
+    forcePositive: true
+  })
   // We need to save the regex filter and ID to check if the rule already exists later.
   savedRegexFilters.set(regexFilter, { id, regexSubstitution })
   return generateAddRule(id, regexFilter, regexSubstitution, excludedInitiatorDomains)

package.json

@@ -111,6 +111,7 @@
     "css-loader": "6.7.2",
     "download-cli": "1.1.1",
     "exponential-backoff": "^3.1.0",
+    "fast-hash-code": "^2.1.0",
     "file-loader": "6.2.0",
     "fs-promise": "2.0.3",
     "get-firefox": "5.0.0",