This repository has been archived by the owner on Mar 10, 2020. It is now read-only.
fix: handle peer-info validation errors #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE. Previously swarm.peers would throw an uncaught error if any peer in the reponse could have its peerId or multiaddr validated. This PR catches errors that occur while validating the peer info. The returned array will contain an entry for every peer in the ipfs response. peer-info objects that couldn't be validated, now have an `error` property and a `rawPeerInfo` property. This at least means the count of peers in the response will be accurate, and there the info is available to the caller. This means that callers now have to deal with peer-info objects that may not have a `peer or `addr` property. Adds `nock` tests to exercice the code under different error conditions. Doing so uncovered a bug in our legacy go-ipfs <= 0.4.4 peer info parsing, which is also fixed. The code was trying to decapusalate the peerId from the multiaddr, but doing so trims the peerId rather than returning it. fixes #885 License: MIT Signed-off-by: Oli Evans <[email protected]>
ghost
assigned 
|
This also fixes ipfs/ipfs-webui#878 |
|
I need to figure out how to tell ageir to only run the |
|
@olizilla Remove the |
License: MIT Signed-off-by: Oli Evans <[email protected]>
License: MIT Signed-off-by: Oli Evans <[email protected]>
alanshaw
suggested changes
Nov 9, 2018
There was a problem hiding this comment.
Code LGTM. Do you have a moment to PR https://github.com/ipfs/interface-ipfs-core/blob/master/SPEC/SWARM.md#swarmpeers to make a note of the change?
|
@alanshaw related to our conversations about the multiaddr validation problem, I found this multiformats/multiaddr#70 |
olizilla
added a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Nov 13, 2018
js-ipfs-api can encounter individual peer info objects that have newer multiaddrs or, in theory, a new format for PeerId that it cannot parse. Allowing for individiual peerInfo validation errors allows us to return a response which has the right number of peers in, and peerId and multiaddr info for all the other peers that could be validated, along with a info about peers that failed to validate. See: ipfs-inactive/js-ipfs-http-client#887
|
The There is a PR to update the interface-core spec here ipfs-inactive/interface-js-ipfs-core#393 |
daviddias
pushed a commit
to ipfs-inactive/interface-js-ipfs-core
that referenced
this pull request
Nov 14, 2018
js-ipfs-api can encounter individual peer info objects that have newer multiaddrs or, in theory, a new format for PeerId that it cannot parse. Allowing for individiual peerInfo validation errors allows us to return a response which has the right number of peers in, and peerId and multiaddr info for all the other peers that could be validated, along with a info about peers that failed to validate. See: ipfs-inactive/js-ipfs-http-client#887
License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
approved these changes
Nov 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE. Previously swarm.peers would throw an uncaught error
if any peer in the reponse couldn't have its peerId or multiaddr validated.
This PR catches errors that occur while validating the peer info. The
returned array will contain an entry for every peer in the ipfs response.
peer-info objects that couldn't be validated, now have an
errorpropertyand a
rawPeerInfoproperty. This at least means the count of peers inthe response will be accurate, and there the info is available to the caller.
This means that callers now have to deal with peer-info objects that may
not have a
peeroraddrproperty.Adds
nocktests to exercice the code under different error conditions.Doing so uncovered a bug in our legacy go-ipfs <= 0.4.4 peer info parsing,
which is also fixed. The code was trying to decapusalate the peerId from
the multiaddr, but doing so trims the peerId rather than returning it.
fixes #885
License: MIT
Signed-off-by: Oli Evans [email protected]