Add a skipAnimation option to addItem to avoid initial collapse animatio... #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 18, 2012 13:09
|
Hello Richard, You are adding skipAnimation parameter to _processItems and _collapseItem functions, but such parameter should be added to _expandItem too (and after that to _processExpanding). Btw, Accordion currently provides an attribute, useAnimation. If you set it to false just before adding your item and then set it to true again, does this solve your problem? Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the pull request from a branch of yui3 gallery with the changes. The last commit should just be the one to cherry pick. I removed the debugger and fixed the typo and rebased that back down to a single commit.
Let me know if there's anything else I can do to help.