Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: capacitor binding yarn issue affecting Windows #2452

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

kraftjs
Copy link
Contributor

@kraftjs kraftjs commented Feb 28, 2022

Summary

Please summarize your changes, describing what they are and why they were made.
An issue with Yarn is causing yarn workspaces to fail on Windows when there is a script that utilizes a dependency before the yarn workspace is instantiated. The capacitor bindings workspace needs a preinstall script that uses rimraf to support its functionality, which is causing Windows to fail.

This PR adds a node script to the capacitor workspace that is instead called in the preinstall script.

Changelog

- Added script to packages/backend/bindings/capacitor/scripts that calls correct dependency path
- Changed package.json scripts to use this new script

Relevant Issues

Closes #2450

Type of Change

Please select any type below that is applicable to your changes, and delete those that are not.

  • Fix - a change which fixes an issue

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

  • @amadeu2 Please confirm that mobile functionality remains intact after these changes and that yarn doesn't fail on a Linux OS.
  • @maxwellmattryan Please confirm that yarn doesn't fail on Windows with this change.

Checklist

Please tick all of the following boxes that are relevant to your changes, and delete those that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have verified that my latest changes pass CI workflows for testing and linting

@kraftjs kraftjs added os:windows Affects Windows platform type:fix Fix for bug package:backend labels Feb 28, 2022
@kraftjs kraftjs added this to the Mobile 1.0.0-alpha milestone Feb 28, 2022
@kraftjs kraftjs requested a review from cvarley100 as a code owner February 28, 2022 23:03
@kraftjs kraftjs self-assigned this Feb 28, 2022
Copy link
Contributor

@amadeu2 amadeu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solved 👌 works like a charm!

@amadeu2 amadeu2 merged commit caa9200 into develop Mar 1, 2022
@amadeu2 amadeu2 deleted the fix/capacitor-bindings-Windows branch March 1, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os:windows Affects Windows platform type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix Windows build for capacitor bindings workspace
2 participants