Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe option unwrapping analyzer #33

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Unsafe option unwrapping analyzer #33

merged 3 commits into from
Nov 16, 2023

Conversation

sheridanchris
Copy link
Contributor

@sheridanchris sheridanchris commented Nov 15, 2023 •
edited
Loading

Generalizes the existing analyzer to cover ValueOption and .Value member access
Reference issue: #31

@sheridanchris
Unsafe option unwrapping analyzer
360d688 
Generalizes the existing analyzer to cover ValueOption and `.Value`
member access
@sheridanchris
Update CHANGELOG.md
f76b4b3
@sheridanchris
Copy link
Contributor Author

sheridanchris commented Nov 15, 2023 •
edited
Loading

Is Severity.Hint appropriate for this analyzer? Should this be a warning instead?

nojaf
nojaf approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nojaf
Copy link
Contributor

nojaf commented Nov 16, 2023

Is Severity.Hint appropriate for this analyzer? Should this be a warning instead?

That is a tricky thing, I would be ok with warning here.
Users can always change this via:
image

@nojaf nojaf merged commit d824690 into ionide:main Nov 16, 2023
5 checks passed
@nojaf
Copy link
Contributor

nojaf commented Nov 16, 2023

Thank you!

@sheridanchris sheridanchris deleted the option-unwrapping-analyzer branch November 16, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sheridanchris @nojaf