Skip to content

Commit

Permalink
Merge pull request #26 from nojaf/walk-synval-sig
Browse files Browse the repository at this point in the history
Bump FSharp.Analyzers.SDK
  • Loading branch information
nojaf authored Nov 13, 2023
2 parents 2472cbf + 2cdd18c commit 648585f
Show file tree
Hide file tree
Showing 6 changed files with 32 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
]
},
"fsdocs-tool": {
"version": "20.0.0-alpha-008",
"version": "20.0.0-alpha-009",
"commands": [
"fsdocs"
]
Expand Down
7 changes: 7 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Automatically normalize line endings
* text=auto

# Always use lf for F# files
*.fs text eol=lf
*.fsx text eol=lf
*.fsi text eol=lf
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 0.3.0 - 2023-11-13

### Changed
* Update FSharp.Analyzers.SDK to v0.20.0. [#26](https://github.com/ionide/ionide-analyzers/pull/26)

## 0.2.0 - 2023-11-09

### Fixed
Expand Down
1 change: 1 addition & 0 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
<PackageTags>F#, fsharp, analyzers</PackageTags>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<RepositoryUrl>https://github.com/ionide/ionide-analyzers</RepositoryUrl>
<DebugType>embedded</DebugType>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageReadmeFile>README.md</PackageReadmeFile>
Expand Down
4 changes: 2 additions & 2 deletions Directory.Packages.props
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PackageVersion Include="NUnit3TestAdapter" Version="4.5.0" />
</ItemGroup>
<ItemGroup Condition="'$(UseLocalAnalyzersSDK)' == 'false'">
<PackageVersion Include="FSharp.Analyzers.SDK" Version="[0.19.0]" />
<PackageVersion Include="FSharp.Analyzers.SDK.Testing" Version="[0.19.0]" />
<PackageVersion Include="FSharp.Analyzers.SDK" Version="[0.20.0]" />
<PackageVersion Include="FSharp.Analyzers.SDK.Testing" Version="[0.20.0]" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,19 @@ let a (b: string[]) = ()
Assert.IsNotEmpty msgs
Assert.IsTrue(Assert.messageContains "Prefer postfix syntax for arrays." msgs[0])
}

[<Test>]
let ``int array in val sig`` () =
async {
let source =
"""
module M
val a: b: int[] -> unit
"""

let ctx = getContextForSignature projectOptions source
let! msgs = squareBracketArrayAnalyzer ctx
Assert.IsNotEmpty msgs
Assert.IsTrue(Assert.messageContains "Prefer postfix syntax for arrays." msgs[0])
}

0 comments on commit 648585f

Please sign in to comment.