-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple unreleased version and BuildDate config #35
base: main
Are you sure you want to change the base?
Conversation
- Simply take the latest version, increment patch, add -alpha. - Handle changelogs with no releases. - Hanlde changelogs with no releases nor unreleased - Add targets from ionide#5 which conditionally use the unreleased version in packaging
@baronfel I haven't added the configuration property for the |
The configuration would mostly come in because some people may not want dates of any kind 'stamped' into the assembly - Dates are a common source of non-determinism in builds and so it's common practice to either pin the date to UNIX epoch, omit the date entirely, or via some other means use a consistent date. I think it's safe-ish for this library because we would emit the date that's in the Changelog (and so would be stable), I'm just a bit cautious about dates in binaries in general. |
@baronfel Could you check that I've set appropriate To be honest, I'm not entirely sure why it wasn't necessary before, unless the assembly wasn't having the version written to it? Or unspecified ordering getting lucky? |
Good point on the timing. There are 4 scenarios we need to care about to make sure all the versions are set at the right times and places:
|
@baronfel I've added testing for BuildDate + config, so I think this PR is ready. I'll look into the more sophisticated version bumping, and maybe creating a test solution with the different combinations. I'm going on holiday at the end of this week though, so that might not be imminent :) |
WHAT
This partially implements the automatic pre-release version bumping from #5. It's currently a very simply increment patch + "-alpha".
It also
WHY
It makes sense to try to prevent accidental publishing under old version numbers.
WHAT NOT
This doesn't do the clever major/minor/patch derivation, nor height.