-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test infrastructure #88
Conversation
- add a sample unit test project for the option sample
# Conflicts: # src/FSharp.Analyzers.Cli/Program.fs # src/FSharp.Analyzers.SDK/FSharp.Analyzers.SDK.Client.fs # src/FSharp.Analyzers.SDK/FSharp.Analyzers.SDK.fs
- use a list of packages - make creation of FSharpProjectOptions more robust and add debug infos
…arp.Analyzers.SDK into test_infrastructure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits left but I'm really happy with this setup.
Please consider adding some documentation about this as well.
Something a la "Write your first unit test"
- rename module "AssertionHelpers" to "Assert" - rename funcition "areWarningsInLines" to "hasWarningsInLines" - shuffle order of "hasWarningsInLines"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'm going to merge this in to play around with the testing story in my current work.
This refactors some code to make unit testing with the SDK easier.
To make really sure we are using valid
FSharpProjectOptions
with all platforms and framework versions we make some effort to create a temporary project and read the options from it.This is currently not working for net8, see here