Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSharp.Compiler.Service and FSharp.Core to the '9' versions #222

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

Numpsy
Copy link
Contributor

@Numpsy Numpsy commented Nov 13, 2024

refs #221

Note: I'm trying to learn a bit more about how this stuff works, so I'm not certain how the new null AST bits like SynType.WithNull should be handled

@nojaf
Copy link
Contributor

nojaf commented Nov 14, 2024

so I'm not certain how the new null AST bits like SynType.WithNull should be handled

That bit looked fine to me.

@Numpsy Numpsy marked this pull request as ready for review November 14, 2024 18:19
Copy link
Member

@TheAngryByrd TheAngryByrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Also pushed up changes that make it net8/9. Also gonna mark this as blocked until we release the proj-info package.

Directory.Packages.props Outdated Show resolved Hide resolved
@baronfel baronfel dismissed TheAngryByrd’s stale review November 19, 2024 15:50

The ProjInfo package is released and has been updated here

@baronfel
Copy link
Collaborator

Green! Thank you @Numpsy and @nojaf :) Will push out a new release shortly with this.

@baronfel baronfel merged commit 17329bd into ionide:main Nov 19, 2024
2 checks passed
@Numpsy Numpsy deleted the bump_fcs branch November 19, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants