Performance tweaks for larger solutions #210
Conversation
| if not (isNull formatterOptions.TimestampFormat) then | ||
| let dateTime = | ||
| if formatterOptions.UseUtcTimestamp then | ||
| DateTime.UtcNow | ||
| else | ||
| DateTime.Now | ||
|
|
||
| let timestamp = dateTime.ToString(formatterOptions.TimestampFormat) | ||
|
|
||
| textWriter.Write($"{timestamp} ") |
There was a problem hiding this comment.
Helped with diagnosing slow areas. Not exactly required for this but might be nice to keep.
| | Project _ -> "List of paths to your .fsproj file." | ||
| | Analyzers_Path _ -> | ||
| "List of path to a folder where your analyzers are located. This will search recursively." |
There was a problem hiding this comment.
Noticed these took lists and should give help messages appropriate for them.
| let loader = WorkspaceLoader.Create(toolsPath, properties) | ||
| let parsed = loader.LoadProjects [ projPath ] |> Seq.toList | ||
| let projectOptions = loader.LoadProjects projPaths |
There was a problem hiding this comment.
This is one of the major speed ups. Load all projects at once.
There's some locking that goes on behind the scenes when ProjInfo talks to msbuild becuase msbuild can only handle one build request at a time in process. It's best to front load as many project load requests as you can.
|
|
||
| return fcsPo | ||
| return FCS.mapManyOptions projectOptions |> Seq.toList |
There was a problem hiding this comment.
Another helper that maps to FCS types efficiently.
| } | ||
|
|
||
| let runProjectAux | ||
| let runProject |
There was a problem hiding this comment.
runProjectAux was no longer needed, renamed to runProject
|
|
||
| // Since we did ParseAndCheckProject, we can be sure that the file is in the project. | ||
| // See https://fsharp.github.io/fsharp-compiler-docs/fcs/project.html for more information. | ||
| let! parseAndCheckResults = fcs.GetBackgroundCheckResultsForFileInProject(fileName, fsharpOptions) |
There was a problem hiding this comment.
As the comment mentions, this helps with speedily getting the typecheck for that file since we already checked the project.
| |> List.map (fun (projPath: FSharpProjectOptions) -> | ||
| runProject client projPath exclInclFiles severityMapping | ||
| ) | ||
| |> Async.Parallel |
There was a problem hiding this comment.
Since we front load all projects we can use Async.Parallel to schedule as all the operations.
TheAngryByrd
force-pushed
the
performance-tweaks
branch
from
bb33fe4 to
1f33125
Compare
|
@TheAngryByrd could you retry syncing with the main branch? I believe stuff will work after that. |
TheAngryByrd
force-pushed
the
performance-tweaks
branch
from
4a08afc to
29fba38
Compare
Some performance tweaks for larger solutions when using the CLI tool.
This took my work solution from 15+ minutes to about 2 minutes.