Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document the FullName footgun we run into #177

Merged
merged 1 commit into from
Dec 13, 2023
Merged

document the FullName footgun we run into #177

merged 1 commit into from
Dec 13, 2023

Conversation

dawedawe
Copy link
Contributor

As we have been burned by this multiple times...

nojaf
nojaf approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, thanks.

@dawedawe dawedawe merged commit addb946 into ionide:main Dec 13, 2023
2 checks passed
@dawedawe dawedawe deleted the document_fullname_footgun branch December 13, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dawedawe @nojaf