Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid certain filenames in tarballs (txzchk) #841

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Nov 6, 2023

No description provided.

@xexyl
Copy link
Contributor Author

xexyl commented Nov 6, 2023

I forgot to add the list of files but since the previous commit lists files it probably can be discerned.

I think we might want to add some test cases for both this update and the one with mkiocccentry. However I'm too tired to do that today. If you wish to do that so I can focus on the other repo that'd be welcome. For the txzchk test script see the README.md file in that directory for how to install the error code files.

Otherwise I can get to it another time.

@lcn2
Copy link
Contributor

lcn2 commented Nov 6, 2023

I think we might want to add some test cases for both this update and the one with mkiocccentry. However I'm too tired to do that today

Adding those test cases sometime would be a good way to check if your new code works as you expect.

@lcn2 lcn2 merged commit 62d47c9 into ioccc-src:master Nov 6, 2023
1 check passed
@xexyl
Copy link
Contributor Author

xexyl commented Nov 6, 2023

I think we might want to add some test cases for both this update and the one with mkiocccentry. However I'm too tired to do that today

Adding those test cases sometime would be a good way to check if your new code works as you expect.

Of course. I would normally do it already but I'm so tired right now that I can't do that much :(

It should be fine but please remind me if I don't get to it because it would be good to have it. It's what I built the script for after all!

@xexyl xexyl deleted the txzchk-forbidden-files branch November 6, 2023 22:42
@xexyl
Copy link
Contributor Author

xexyl commented Nov 6, 2023

I'm doing the tarball one now .. will then commit and then that's it for the day. Perhaps you'd like to make one for chkentry ? I did test the mkiocccentry of course: if any of those files are specified then it exits early. So the only one that won't be done by me now is the chkentry one.

@xexyl
Copy link
Contributor Author

xexyl commented Nov 6, 2023

I'm doing the tarball one now .. will then commit and then that's it for the day. Perhaps you'd like to make one for chkentry ? I did test the mkiocccentry of course: if any of those files are specified then it exits early. So the only one that won't be done by me now is the chkentry one.

Done: 5f7b1ea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants