Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support bin IP Adapter files #6452

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Support bin IP Adapter files #6452

wants to merge 2 commits into from

Conversation

blessedcoolant
Copy link
Collaborator

@blessedcoolant blessedcoolant commented May 28, 2024 •
edited
Loading

Merge Plan

Just double check that safetensors adding works as it should still and nothing broke in the process.

Related Issues / Discussions

QA Instructions

Merge Plan

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files backend PRs that change backend files labels May 28, 2024
lstein
lstein approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@lstein lstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lstein
Copy link
Collaborator

lstein commented Aug 10, 2024

Any reason we're not merging this?

@hipsterusername
Copy link
Member

Failing tests, otherwise is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@lstein lstein lstein approved these changes

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@RyanJDick RyanJDick Awaiting requested review from RyanJDick RyanJDick is a code owner

Assignees
No one assigned
Labels
backend PRs that change backend files python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blessedcoolant @lstein @hipsterusername