-
-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Changelog in repo + autorelease #6593
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
I like it! I'm a big fan of user-friendly update notes. You don't need to tell everyone that you changed the return of fn(x) from int to str. Let the users know what they're going to notice. At work, we use the term "politically correct" writing, and I think this fits that bill perfectly! |
@matmair sorry did not get to look at this yet, but let's make it a focus for |
@SchrodingersGat what is your general position on keeping a dedicated CHANGELOG file? Should this target 0.16.0? |
@matmair my main concern is the extra effort it would take to maintain. Could we limit it to major features / fixes / breaking changes? |
I think everything that is breaking and any major new feature (everything we would put into the release notes/blog) should be included |
@matmair this is the last outstanding PR for 0.16.x - is it in a state ready for review / merge? |
Can you explain the workflow that would cause |
Let's move this to 0.17.x |
.github/workflows/do_release.yaml would be run by manually dispatching it. You could select if you wanted to release from master or stable and the action would then gather the auto-generated changelog, add the manual changelog above and create a release. After that the normal release things would start |
Placeholder PR; will sketch further out soon
See #4959, #4623