Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove include and exclude to avoid missing requirements-level #168

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

ptamarit
Copy link
Member

@ptamarit ptamarit commented Feb 27, 2024

❤️ Thank you for your contribution!

Description

GitHub Action problems

The CI action has been failing for some time.
The problem is that the 2 jobs from the include section did not specify a python-version nor a requirements-level, and therefore failing on the requirements-builder ... --level= command.

  • I removed the exclude section with mysql5 since it was later on also specified in the include section.
  • I removed the include section and moved postgresql13 to the db-service matrix; all the other entries were already specified in db-service.

Tests which had been failing

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Third-party code

If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
@ptamarit ptamarit self-assigned this Feb 29, 2024
@slint slint merged commit 35845fe into inveniosoftware:master Mar 1, 2024
8 checks passed
@ptamarit ptamarit deleted the fix-github-action-matrix branch March 1, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants