Tests: check existing username case-insensitive #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/zenodo/ops/issues/326
❤️ Thank you for your contribution!
Description
Usernames are enforced to be unique in the DB regardless of their case (see related DB column and constraint definition).This change applies the same validation at the registration of a user to avoid hitting the DB constraint which is then not well handled by Flask (users end up seeing an nginx 502 error).This is a test-only pull request related to inveniosoftware/invenio-accounts#476.
Here we only improve the test to make sure that
invenio-accounts
properly finds by usernames case-insensitively.Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
Third-party code
If you've added third-party code (copy/pasted or new dependencies), please reach out to an architect.
Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: