deposit-ui: show detailed backend error messages if present

[ptamarit]

❤️ Thank you for your contribution!

Description

This pull request proposes to include more error details from the backend, if present, when an error occurs during record publishing.

This is for instance the case in Zenodo when trying to publish a record with a pending file uploads. This can be either if the file upload failed halfway (can be reproduced with EOS and by reloading the page in the middle of an upload), or if the file is taking a long time to upload (can be reproduced by throttling the network).

In such cases:

1. The PUT on /api/records/1234/draft?expand=1 succeeds
2. The POST on /api/records/1234/draft/actions/publish?expand=1 fails with the following response:

{
  "status": 400,
  "message": "A validation error occurred.",
  "errors": [
    {
      "field": "files",
      "messages": [
        "One or more files have not completed their transfer, please wait."
      ]
    }
  ]
}

We are currently only showing message:

The proposal of adding the info present in the errors array looks like this:

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[ptamarit]

Remark: react-invenio-deposit also has a FormFeedback.js, but it seems that it's not used since #1276.

[slint]

LGTM, minor comment on dealing with multiple errors.

Also, another minor point:

• When accepting a record to a community for a review request, we see a similar validation error in the modal that doesn't include the "real" errors. Is this component used there too?

[slint]

minor: should we do a bullet-list instead (similar to the usual form validation errors), since it's an array?

[carlinmack]

To add on to slint's point: When you try to accept a submission to a community which has pending files, it tells the user "Validation error", does this also fix that?

[github-actions]

This PR was automatically marked as stale.