fix: use new redirect url #1720
Open
+222
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgiesske-intershop
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
For a redirect before checkout payment, the customer is redirected to the PSP using the redirect URL that the ICM generates.
When the customer is back in the PWA and the redirect was successful, he can add further products to the basket, which then triggers a new basket validation in the checkout.
This basket validation returns that a new redirect is necessary (depending on the payment connector implementation) but does not return a new redirect URL.
What Is the New Behavior?
This bug has been fixed in ICM version 12.3.0 and the ICM now returns a new redirect URL on basket validation if adjustments are allowed and if a new redirect is needed.
This PR takes the newly generated URL and stores it in the Store to then perform the redirect with the newly generated URL.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Requires ICM 12.3.0
Azure DevOps Issue: 97415
AB#100804