fix: avoid pgid errors when an apiToken is available #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisie96
force-pushed
the
fix/pgid-with-apiToken
branch
from
7000765
to
66be12f
Compare
Eisie96
force-pushed
the
fix/pgid-with-apiToken
branch
2 times, most recently
from
5d75b15
to
1459e38
Compare
|
We need to talk about https://github.com/intershop/intershop-pwa/blob/develop/src/app/core/store/content/pages/pages.effects.ts#L38 before merging. |
Eisie96
force-pushed
the
fix/pgid-with-apiToken
branch
4 times, most recently
from
5dad199
to
f2c13fe
Compare
Eisie96
force-pushed
the
fix/pgid-with-apiToken
branch
from
f2c13fe
to
343a811
Compare
Eisie96
force-pushed
the
fix/pgid-with-apiToken
branch
from
fce0cd3
to
88350d0
Compare
Eisie96
force-pushed
the
fix/pgid-with-apiToken
branch
from
88350d0
to
e7b22b9
Compare
SGrueber
force-pushed
the
fix/pgid-with-apiToken
branch
from
e7b22b9
to
b6620e5
Compare
SGrueber
force-pushed
the
fix/pgid-with-apiToken
branch
from
c47f02c
to
1752b4b
Compare
SGrueber
pushed a commit
that referenced
this pull request
Jan 31, 2024
*do not load content data from ICM before the pgid of a registered user is available
SGrueber
pushed a commit
that referenced
this pull request
Jan 31, 2024
SGrueber
force-pushed
the
fix/pgid-with-apiToken
branch
from
1752b4b
to
4f3f0a2
Compare
*do not load content data from ICM before the pgid of a registered user is available
SGrueber
pushed a commit
that referenced
this pull request
Mar 20, 2024
SGrueber
force-pushed
the
fix/pgid-with-apiToken
branch
from
4f3f0a2
to
5e71f94
Compare
SGrueber
force-pushed
the
fix/pgid-with-apiToken
branch
from
5e71f94
to
30e3d32
Compare
SGrueber
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
Some ICM REST requests (e.g. /cms/include) will fail, when an apiToken is send without pgid information.
Issue Number: Closes #
What Is the New Behavior?
When an apiToken is available, all REST request will wait until pgid is available in case the option to send the pgid/ spgid is enabled.
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information
Steps to Repeat:
(1) Run the PWA with the
https://pwa-ish-demo.test.intershop.comas configured ICM.(1) Login with a user
(2) Go to the /home page
(3) Refresh the page
(4) Check within Network tab, that
/cms/includes/include.homepage.content.pagelet2-Include RESTrequest fails with following error message:Bad Request (Matrix parameter "pgid" is required if auth token is present)AB#88541