fix issues of denormal inconsistency in purification

interpretml · Dec 24, 2024 · 4094054 · 4094054
1 parent 0a7d04d
commit 4094054
Show file tree

Hide file tree

Showing 3 changed files with 314 additions and 53 deletions.
diff --git a/shared/libebm/PartitionMultiDimensionalTree.cpp b/shared/libebm/PartitionMultiDimensionalTree.cpp
@@ -628,8 +628,8 @@ template<bool bHessian, size_t cCompilerScores> class PartitionMultiDimensionalT
                      ++iDimension;
                   } while(cDimensions != iDimension);
 
-                  constexpr double tolerance =
-                        0.0; // TODO: for now purify to the max, but test tolerances and profile them
+                  // TODO: for now purify to the max, but test tolerances and profile them
+                  constexpr double tolerance = 0.0;
 
                   // TODO: in the future try randomizing the purification order.  It probably doesn't make much
                   // difference