Render IA logo SVG on modal header #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsharma123
changed the title
|
nsharma123
commented
Apr 24, 2024
| @@ -3,9 +3,9 @@ import { property, customElement } from 'lit/decorators.js'; | |||
|
|
|||
| import '@internetarchive/ia-activity-indicator/ia-activity-indicator'; | |||
| import '@internetarchive/icon-close'; | |||
| import iaIcon from '@internetarchive/icon-ia-logo/index.js'; | |||
There was a problem hiding this comment.
I have changed the way to render the ia-logo icon here because it were render JS code here. We were already render the svg icon directly without any any like here.
So using the same SVG file and moved inside this repo to prevent future issues similar like this because we faced this issue many times where the JS code was rendered instead of svg logo.
dualcnhq
approved these changes
Apr 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.