Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style) - make cardgroup grid more responsive #951

Closed
wants to merge 1 commit into from

Conversation

Shashika6
Copy link
Contributor

@Shashika6 Shashika6 commented Apr 17, 2024

Fixes #949

Notes :-

  • Currently cards in card groups do not have the same width and they change bsaed on the content

Screenshot :-

Before :-

Screenshot 2024-04-17 at 16 43 56

After :-

Screenshot 2024-04-17 at 16 45 14

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 490251a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ilo-org/styles Patch
@ilo-org/react Patch
@ilo-org/twig Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for ilo-ui-twig-develop ready!

Name Link
🔨 Latest commit 490251a
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig-develop/deploys/661fb1925e8e310009c599fa
😎 Deploy Preview https://deploy-preview-951--ilo-ui-twig-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for ilo-ui-twig ready!

Name Link
🔨 Latest commit 490251a
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig/deploys/661fb1929fe80d00088d13b9
😎 Deploy Preview https://deploy-preview-951--ilo-ui-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for ilo-ui-react ready!

Name Link
🔨 Latest commit 490251a
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-react/deploys/661fb1927dd5bc0008ecbd2e
😎 Deploy Preview https://deploy-preview-951--ilo-ui-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shashika6 Shashika6 self-assigned this Apr 17, 2024
@Shashika6 Shashika6 requested a review from justintemps April 17, 2024 11:17
@Shashika6 Shashika6 force-pushed the fix/style/cardgroup branch from f7e45b6 to 490251a Compare April 17, 2024 11:25
@justintemps justintemps deleted the fix/style/cardgroup branch July 10, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Styles: Cards in group have unequal image heights
2 participants