Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Bottom Border #1290

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Link Bottom Border #1290

merged 3 commits into from
Dec 23, 2024

Conversation

GGKapanadze
Copy link
Member

Description

This PR updates the bottom decoration color for the link based on the design

image

@GGKapanadze GGKapanadze self-assigned this Dec 20, 2024
@GGKapanadze GGKapanadze linked an issue Dec 20, 2024 that may be closed by this pull request
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for ilo-ui-react ready!

Name Link
🔨 Latest commit 068ff8e
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-react/deploys/676919d97473580008f60990
😎 Deploy Preview https://deploy-preview-1290--ilo-ui-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for ilo-ui-twig ready!

Name Link
🔨 Latest commit 068ff8e
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig/deploys/676919d988875000081d7b5b
😎 Deploy Preview https://deploy-preview-1290--ilo-ui-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for ilo-ui-twig-develop ready!

Name Link
🔨 Latest commit 068ff8e
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig-develop/deploys/676919d988875000081d7b5f
😎 Deploy Preview https://deploy-preview-1290--ilo-ui-twig-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@justintemps
Copy link
Member

Hey @GGKapanadze, here's how a visited link links to me right now:

image

@GGKapanadze
Copy link
Member Author

That purple indicates that the link was visited that was there before, the issue only mentioned the underling color

@GGKapanadze
Copy link
Member Author

I'll try to update visited state too

Copy link

changeset-bot bot commented Dec 23, 2024

🦋 Changeset detected

Latest commit: 068ff8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ilo-org/styles Patch
@ilo-org/react Patch
@ilo-org/twig Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@justintemps justintemps merged commit 947b055 into develop Dec 23, 2024
13 checks passed
@justintemps justintemps deleted the fix/link-border branch December 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link: colour of underline should be ILO blue
2 participants