Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Improvent #1287

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Tabs Improvent #1287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c61b2
feat(styles): added improvements by base theme
GGKapanadze Dec 20, 2024
7f86da2
build: added changeset
GGKapanadze Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/little-needles-sit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ilo-org/styles": patch
---

added tab improvements by base theme
39 changes: 39 additions & 0 deletions packages/styles/scss/components/_tabs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,14 @@
&[aria-selected="true"] {
background-color: $color-base-neutrals-white;
border-top: px-to-rem(3px) solid $color-ux-labels-actionable;
pointer-events: none;
@include globaltransition("color, background-color, border-color");
}

&[aria-selected="false"]:not(:hover) {
border-top: px-to-rem(3px) solid transparent;
}

&.icon {
.ilo--icon {
height: px-to-rem(16px);
Expand Down Expand Up @@ -174,3 +179,37 @@
}
}
}

// This was proposed by base theme but isn't implemented in the design system yet
.ilo--tabs--secondary {
display: flex;
flex-wrap: wrap;
margin-block: 2rem;
gap: 10px;

.ilo--tabs--selection--button {
display: block;
padding: 0.2em 1em;
font-size: 16px;
font-weight: 600;
color: #230050;
text-decoration: none;

&[aria-selected="false"] {
border-bottom: 2px solid transparent;
background-color: var(--ilo-color-background-highlight);

&:hover {
color: var(--ilo-color-blue);
border-bottom-color: var(--ilo-color-blue);
background-color: var(--ilo-color-background-hover);
}
}

&[aria-selected="true"] {
color: var(--ilo-color-blue-dark);
border-bottom: 2px solid var(--ilo-color-blue-dark);
pointer-events: none;
}
}
}
Loading