-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark overlay when search bar is open #1197
Conversation
🦋 Changeset detectedLatest commit: fe9cca6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ilo-ui-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ilo-ui-twig-develop ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ilo-ui-twig ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c1d8970
to
594e893
Compare
@justintemps what do you think about this implementation :) |
Looks like theres an issue with the build in twig @GGKapanadze said he will have a look at it. |
The styling issue is resolved right now we have to check why the search isn't propagating the correct js inside the base theme. \cc @Shashika6 |
Thanks @GGKapanadze will have a look a this one. |
47cd76f
to
248f7b4
Compare
@justintemps this seems to be okay now will do a bit more testing on this and this should be ready :) |
dea3fdb
to
476e0a1
Compare
This is ready for review :) |
Hey @Shashika6 I think this needs a closer look. The transitions look really janky to me.
It's not a very smooth user experience. Screen.Recording.2024-10-01.at.09.28.19.mov |
Sure @justintemps, Will fix the UX issues. |
476e0a1
to
b81f614
Compare
b81f614
to
fe9cca6
Compare
Hey @justintemps I fixed the transition issues you mentioned can you have a look now :) |
Fixes #783
Notes
Screenshot