Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark overlay when search bar is open #1197

Closed
wants to merge 1 commit into from

Conversation

Shashika6
Copy link
Contributor

@Shashika6 Shashika6 commented Sep 9, 2024

Fixes #783

Notes

  • Add dark overlay when search is open

Screenshot

Screenshot 2024-09-09 at 10 38 57

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: fe9cca6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ilo-org/react Patch
@ilo-org/twig Patch
@ilo-org/styles Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for ilo-ui-react ready!

Name Link
🔨 Latest commit fe9cca6
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-react/deploys/66fce173d49d8d0008c5abd0
😎 Deploy Preview https://deploy-preview-1197--ilo-ui-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for ilo-ui-twig-develop ready!

Name Link
🔨 Latest commit fe9cca6
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig-develop/deploys/66fce1732b75560008b63c68
😎 Deploy Preview https://deploy-preview-1197--ilo-ui-twig-develop.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for ilo-ui-twig ready!

Name Link
🔨 Latest commit fe9cca6
🔍 Latest deploy log https://app.netlify.com/sites/ilo-ui-twig/deploys/66fce1732b75560008b63c66
😎 Deploy Preview https://deploy-preview-1197--ilo-ui-twig.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shashika6 Shashika6 changed the title feat(twig) - add dark overlay to twig navigation Add dark overlay when search bar is open Sep 9, 2024
@Shashika6 Shashika6 force-pushed the feat/react-twig/navigation branch from c1d8970 to 594e893 Compare September 12, 2024 05:56
@Shashika6 Shashika6 marked this pull request as ready for review September 12, 2024 11:35
@Shashika6
Copy link
Contributor Author

@justintemps what do you think about this implementation :)

@Shashika6
Copy link
Contributor Author

Looks like theres an issue with the build in twig @GGKapanadze said he will have a look at it.

@GGKapanadze
Copy link
Member

The styling issue is resolved right now we have to check why the search isn't propagating the correct js inside the base theme. \cc @Shashika6

@Shashika6
Copy link
Contributor Author

Thanks @GGKapanadze will have a look a this one.

@Shashika6 Shashika6 closed this Sep 27, 2024
@Shashika6 Shashika6 force-pushed the feat/react-twig/navigation branch from 47cd76f to 248f7b4 Compare September 27, 2024 05:43
@Shashika6 Shashika6 reopened this Sep 27, 2024
@Shashika6
Copy link
Contributor Author

@justintemps this seems to be okay now will do a bit more testing on this and this should be ready :)

@Shashika6 Shashika6 force-pushed the feat/react-twig/navigation branch 2 times, most recently from dea3fdb to 476e0a1 Compare September 27, 2024 17:31
@Shashika6
Copy link
Contributor Author

This is ready for review :)

@justintemps
Copy link
Member

Hey @Shashika6 I think this needs a closer look. The transitions look really janky to me.

  1. Why is the search menu sliding out from the top blue part of the nav?
  2. The search icon blinks weirdly when you click on it

It's not a very smooth user experience.

Screen.Recording.2024-10-01.at.09.28.19.mov

@Shashika6
Copy link
Contributor Author

Sure @justintemps, Will fix the UX issues.

@Shashika6 Shashika6 force-pushed the feat/react-twig/navigation branch from 476e0a1 to b81f614 Compare October 2, 2024 05:59
@Shashika6 Shashika6 force-pushed the feat/react-twig/navigation branch from b81f614 to fe9cca6 Compare October 2, 2024 06:00
@Shashika6
Copy link
Contributor Author

Hey @justintemps I fixed the transition issues you mentioned can you have a look now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search: add dark overlay when search bar is open
3 participants