Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Pools): remove ratio customization #1541

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

danielsimao
Copy link
Member

Interbtc UI Pull Request Template

Description

Custom ration on inputs was leading a lot of users to failing transactions

Current behaviour (updates)

Changing input A and then customising the input B leads leads to custom ratio

New behaviour

Pool ratio is always applied

Reproducible testing steps:

go to pools
open deposit modal
Change input A
change input B
See that input A is changed to current ratio

@danielsimao danielsimao linked an issue Aug 25, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 9:58am
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 9:58am
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 9:58am
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 9:58am

@github-actions
Copy link

Running Lighthouse audit...

@danielsimao danielsimao merged commit b8b99ae into master Aug 25, 2023
5 checks passed
@danielsimao danielsimao deleted the rui/pools-improve-form-status-on-pool-deposit branch August 25, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pools] Improve form status on pool deposit
2 participants