Peter/strategy feat proxy account #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterslany
force-pushed
the
peter/strategy-feat-proxy-account
branch
from
e5e021d
to
22fa638
Compare
danielsimao
approved these changes
Sep 1, 2023
danielsimao
approved these changes
Sep 7, 2023
src/pages/Strategies/components/StrategyForm/StrategyDepositForm.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1525
This PR introduces proxy accounts as representation for strategy position. This approach works well for 1 strategy, but when more strategies will be added we'll need to figure out how to uniquely assign proxy address to given strategy and distinguish between them.
Another downside of this approach is that it is not possible to query proxies by delegate accounts so all proxy accounts have to be obtained and then filtered which is not scalable at all.
Lastly, this approach adds another step of UX complexity - proxy account has to be first initialized and only then the strategy can be used.