Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Staking): refactor #1538

Merged
merged 16 commits into from
Nov 6, 2023
Merged

feat(Staking): refactor #1538

merged 16 commits into from
Nov 6, 2023

Conversation

danielsimao
Copy link
Member

@danielsimao danielsimao commented Aug 23, 2023

Interbtc UI Pull Request Template

Description

Missing freeStakable

@danielsimao danielsimao linked an issue Aug 23, 2023 that may be closed by this pull request
@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interbtc-ui-interlay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 11:58am
interbtc-ui-interlay-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 11:58am
interbtc-ui-kintsugi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 11:58am
interbtc-ui-kintsugi-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 11:58am

@github-actions
Copy link

Running Lighthouse audit...

@tomjeatt
Copy link
Collaborator

There's a bug with this release—if a user is connected with an account that has an staking balance, the application crashes:

TypeError: window.bridge.api.rpc.escrow.freeStakable is not a function
    at l (use-get-account-staking-data.tsx:52:53)

@peterslany could you have a look at this? I think it's related to the bug fix for reward estimation.

@peterslany
Copy link
Contributor

There's a bug with this release—if a user is connected with an account that has an staking balance, the application crashes:

TypeError: window.bridge.api.rpc.escrow.freeStakable is not a function
    at l (use-get-account-staking-data.tsx:52:53)

@peterslany could you have a look at this? I think it's related to the bug fix for reward estimation.

@tomjeatt this issue is probably because the nodes UI uses are still runing old version where the freeStakable RPC call is not exposed

@tomjeatt
Copy link
Collaborator

tomjeatt commented Oct 30, 2023

@tomjeatt this issue is probably because the nodes UI uses are still runing old version where the freeStakable RPC call is not exposed

Thanks @peterslany—can you handle updating this? Would be great to get this wrapped up,

@peterslany
Copy link
Contributor

@tomjeatt this issue is probably because the nodes UI uses are still runing old version where the freeStakable RPC call is not exposed

Thanks @peterslany—can you handle updating this? Would be great to get this wrapped up,

@tomjeatt yes, can you please share more details in which environment the mentioned bug occurs? So that I can ask Nikolai to check the version of RPC node.

@tomjeatt
Copy link
Collaborator

tomjeatt commented Oct 30, 2023

@tomjeatt yes, can you please share more details in which environment the mentioned bug occurs? So that I can ask Nikolai to check the version of RPC node.

I've seen it in all environments—very easy to replicate, you need to connect an account which has an existing stake and you'll see the staking page crash.

Edit:
Although the error on Kintsugi testnet is different—Error: Cannot read properties of undefined (reading 'name').Please refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor staking page
3 participants