fix(SendAndReceive): remove dry-run from xcm (#1540)

src/hooks/transaction/hooks/use-transaction.ts

@@ -70,7 +70,16 @@ function useTransaction<T extends Transaction>(
         onReady: () => onSigning(params)
       };
 
-      return submitTransaction(window.bridge.api, params.accountAddress, feeWrappedExtrinsic, expectedStatus, events);
+      const shouldDryRun = params.type !== Transaction.XCM_TRANSFER;
+
+      return submitTransaction(
+        window.bridge.api,
+        params.accountAddress,
+        feeWrappedExtrinsic,
+        expectedStatus,
+        events,
+        shouldDryRun
+      );
     },
     [feeData?.amount, onSigning, pools]
   );

src/hooks/transaction/submission/submit.ts

@@ -15,7 +15,8 @@ const handleTransaction = async (
   account: AddressOrPair,
   extrinsicData: ExtrinsicData,
   expectedStatus?: ExtrinsicStatus['type'],
-  callbacks?: TransactionEvents
+  callbacks?: TransactionEvents,
+  shouldDryRun?: boolean
 ) => {
   let isComplete = false;
 
@@ -28,7 +29,7 @@ const handleTransaction = async (
       // Extrinsic is signed at first and then we use the same signed extrinsic
       // for dry-running and submission.
       .signAsync(account, { nonce: -1 })
-      .then(dryRun)
+      .then((signedExtrinsic) => (shouldDryRun ? dryRun(signedExtrinsic) : signedExtrinsic))
       .then((signedExtrinsic) => signedExtrinsic.send(callback))
       .then((unsub) => (unsubscribe = unsub))
       .catch((error) => reject(error));
@@ -59,16 +60,24 @@ const handleTransaction = async (
  * @param {ExtrinsicData} extrinsicData transaction extrinsic data
  * @param {ExtrinsicStatus.type} expectedStatus status where the transaction is counted as fulfilled
  * @param {TransactionEvents} callbacks a set of events emitted accross the lifecycle of the transaction (i.e Bro)
+ * @param {boolean} shouldDryRun wether dry run should be executed
  * @return {Promise<ISubmittableResult>} transaction data that also can contain meta data in case of error
  */
 const submitTransaction = async (
   api: ApiPromise,
   account: AddressOrPair,
   extrinsicData: ExtrinsicData,
   expectedStatus?: ExtrinsicStatus['type'],
-  callbacks?: TransactionEvents
+  callbacks?: TransactionEvents,
+  shouldDryRun?: boolean
 ): Promise<TransactionResult> => {
-  const { result, unsubscribe } = await handleTransaction(account, extrinsicData, expectedStatus, callbacks);
+  const { result, unsubscribe } = await handleTransaction(
+    account,
+    extrinsicData,
+    expectedStatus,
+    callbacks,
+    shouldDryRun
+  );
 
   unsubscribe();