Peter/fix loans incentive apr computation (#1256)

* chore: update monetary to latest 0.7.3 * fix: convert incentives apr computation to percentage * fix: change loans incentives annualized return to have label APR
interlay · Jun 9, 2023 · 6f2972d · 6f2972d · vercel · Jun 9, 2023
1 parent 4bf3e13
commit 6f2972d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/components/LoanApyTooltip/BreakdownGroup.tsx b/src/components/LoanApyTooltip/BreakdownGroup.tsx
@@ -29,7 +29,7 @@ const BreakdownGroup = ({ apy, rewardsApy, ticker, rewardsTicker, isBorrow }: Br
           </StyledApyTooltipGroup>
           {!!rewardsApy && (
             <StyledApyTooltipGroup gap='spacing1' wrap>
-              <Dd color='tertiary'>Rewards APY {rewardsTicker}:</Dd>
+              <Dd color='tertiary'>Rewards APR {rewardsTicker}:</Dd>
               <Dt color='primary'>{getApyLabel(rewardsApy)}</Dt>
             </StyledApyTooltipGroup>
           )}

diff --git a/src/pages/Loans/LoansOverview/components/LoanActionInfo/RewardsGroup.tsx b/src/pages/Loans/LoansOverview/components/LoanActionInfo/RewardsGroup.tsx
@@ -26,7 +26,7 @@ const RewardsGroup = ({ isBorrow, apy, assetCurrency, rewards, prices }: Rewards
   return (
     <>
       <DlGroup justifyContent='space-between'>
-        <Dt>Rewards APY {rewards.currency.ticker}</Dt>
+        <Dt>Rewards APR {rewards.currency.ticker}</Dt>
         <Dd>{getApyLabel(subsidyRewardApy)}</Dd>
       </DlGroup>
       <DlGroup justifyContent='space-between'>

diff --git a/src/utils/helpers/loans.ts b/src/utils/helpers/loans.ts
@@ -41,7 +41,7 @@ const getSubsidyRewardApy = (
   }
 
   const exchangeRate = rewardCurrencyPriceUSD / positionCurrencyPriceUSD;
-  const apy = reward.toBig().mul(exchangeRate);
+  const apy = reward.toBig().mul(exchangeRate).mul(100);
 
   return apy;
 };