Skip to content

Commit

Permalink
Version 9.1.0
Browse files Browse the repository at this point in the history
  • Loading branch information
Przemyslaw Dabrowski authored and Przemysław committed Jul 20, 2020
1 parent ac8acbf commit 9032933
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Intercom for Cordova/PhoneGap

## 9.1.0 (2020-07-20)

* The Cordova plugin has been updated to be compatible with v7.2.0 of the Android SDK and v9.0.0 of Cordova Android.

This comment has been minimized.

Sign in to view

Copy link
@jskrepnek

jskrepnek Sep 1, 2020

Contributor

@CodeFactoryPDabrowski @CodeFactoryPDabrowski I do not believe that the plugin is currently compatible with Cordova Android 9, due to incompatibilities with Gradle 6.5, which is the default version.

These lines are the culprits:

if (pushType == 'fcm') {
    tasks.copyGoogleServices.execute()
    apply plugin: com.google.gms.googleservices.GoogleServicesPlugin
} else if (pushType == 'fcm-without-build-plugin') {
    tasks.copyGoogleServices.execute()
    logger.info("Not applying GoogleServicesPlugin from Intercom plugin, another plugin should do this")
}

They lead to an error:

Could not find method execute() for arguments

Execute was removed in more recent versions of Gradle.

I've successfully updated that code locally to the following:

gradle.taskGraph.whenReady {
   copyGoogleServices
}

if (pushType == 'fcm') {
    apply plugin: com.google.gms.googleservices.GoogleServicesPlugin
} else if (pushType == 'fcm-without-build-plugin') {
    logger.info("Not applying GoogleServicesPlugin from Intercom plugin, another plugin should do this")
}

This comment has been minimized.

Sign in to view

Copy link
@jskrepnek

jskrepnek Sep 1, 2020

Contributor

https://community.intercom.com/t/cordova-android-9-and-cordova-intercom-9-1/2235

This comment has been minimized.

Sign in to view

Copy link
@CodeFactoryPDabrowski

CodeFactoryPDabrowski Sep 2, 2020

Contributor

I'll check that 💪
* v7.2.0 of the Android SDK now uses [Android X](https://developer.android.com/jetpack/androidx), and includes updates to the Gson and Firebase Messaging libraries it uses.
* In [Cordova Android v9.0.0](https://cordova.apache.org/announcements/2020/06/29/cordova-android-9.0.0.html), the minimum Android API level is now API 22 (Android 5.1). The Cordova plugin's minimum version is now API 22 as well.

## 9.0.1 (2020-07-08)

The Intercom Cordova plugin has been updated to use v7.1.1 of the iOS and Android SDK. We fixed a number of bugs in this release:
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ cordova plugin add cordova-plugin-intercom

To add the plugin to your PhoneGap app, add the following to your `config.xml`:
```xml
<plugin name="cordova-plugin-intercom" version="~9.0.1" />
<plugin name="cordova-plugin-intercom" version="~9.1.0" />
```

## Example App
Expand Down
2 changes: 1 addition & 1 deletion intercom-plugin/package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cordova-plugin-intercom",
"version": "9.0.1",
"version": "9.1.0",
"description": "Official Cordova/PhoneGap plugin for Intercom",
"cordova": {
"id": "cordova-plugin-intercom",
Expand Down
2 changes: 1 addition & 1 deletion intercom-plugin/plugin.xml
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<?xml version='1.0' encoding='utf-8'?>
<plugin id="cordova-plugin-intercom" version="9.0.1" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
<plugin id="cordova-plugin-intercom" version="9.1.0" xmlns="http://apache.org/cordova/ns/plugins/1.0" xmlns:android="http://schemas.android.com/apk/res/android">
<name>Intercom</name>
<author>Intercom</author>
<license>MIT License</license>
Expand Down

0 comments on commit 9032933

Please sign in to comment.