Update for PROJ version 8, support enforcement of lon/lat axis #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekakh
commented
Sep 8, 2021
bekakh
commented
- Update PROJ-JNI to support PROJ 8.
- Add support for lon/lat axis enforcement.
bekakh
commented
Sep 20, 2021
src/main/cpp/bindings.cpp
Outdated
Comment on lines
2685
to
2687
| CRSNNPtr crs = get_shared_object<CRS>(env, operation); | ||
| BaseObjectPtr ptr = crs.as_nullable(); | ||
| return specific_subclass(env, operation, ptr, org_kortforsyningen_proj_Type_COORDINATE_REFERENCE_SYSTEM); |
There was a problem hiding this comment.
@azahnen this code segment does nothing to the CRS. Should it be always converting the CRS to CRS:84?
There was a problem hiding this comment.
The line that does the actual axis order switch is missing:
Suggested change
| CRSNNPtr crs = get_shared_object<CRS>(env, operation); | |
| BaseObjectPtr ptr = crs.as_nullable(); | |
| return specific_subclass(env, operation, ptr, org_kortforsyningen_proj_Type_COORDINATE_REFERENCE_SYSTEM); | |
| CRSNNPtr crs = get_shared_object<CRS>(env, operation); | |
| crs = crs->normalizeForVisualization(); | |
| BaseObjectPtr ptr = crs.as_nullable(); | |
| return specific_subclass(env, operation, ptr, org_kortforsyningen_proj_Type_COORDINATE_REFERENCE_SYSTEM); |
|
After these changes, lon/lat axis enforcement still isn't working. |
|
Never mind, it was a local problem. Axis enforcement works well after the changes. |
This reverts commit 5f9258c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.