Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor fixes to grafana scripts #611

Merged
merged 1 commit into from
Feb 2, 2024
Merged

minor fixes to grafana scripts #611

merged 1 commit into from
Feb 2, 2024

Conversation

vimalk78
Copy link
Contributor

Updated scripts to

  • use network instead of link
  • use podman or docker

opcm
opcm requested changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@opcm opcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the change. Would you mind to make it run on docker-only based systems too as default? using podman should be an additional option. There are also README files in PCM which refer to docker (git grep docker)

@vimalk78
Copy link
Contributor Author

thanks for the change. Would you mind to make it run on docker-only based systems too as default? using podman should be an additional option. There are also README files in PCM which refer to docker (git grep docker)

@opcm updated as per your suggestion.

@vimalk78 vimalk78 changed the title changed grafana scripts to use podman minor fixes to grafana scripts Nov 25, 2023
opcm
opcm requested changes Nov 26, 2023
View reviewed changes
scripts/grafana/start.sh Outdated
echo Starting telegraf
docker run -d --name telegraf --link=influxdb -v $PWD/telegraf.conf:/etc/telegraf/telegraf.conf:ro telegraf
${CTR_RUN} run -d --name telegraf --network=influxdb -v $PWD/telegraf.conf:/etc/telegraf/telegraf.conf:ro telegraf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be influxdb-network

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

scripts/grafana/start.sh Outdated
echo Starting grafana
docker run -d --link=influxdb --name grafana -p 3000:3000 -v $PWD/provisioning:/etc/grafana/provisioning -v $PWD/grafana_volume:/var/lib/grafana grafana/grafana
${CTR_RUN} run -d --network=influxdb --name grafana -p 3000:3000 -v $PWD/provisioning:/etc/grafana/provisioning -v $PWD/grafana_volume:/var/lib/grafana grafana/grafana
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@vimalk78
minor fixes to grafana scripts
c9c6cd0 
  Updated scripts to
  - use network instead of link
  - use podman or docker

Signed-off-by: Vimal Kumar <[email protected]>
@vimalk78
Copy link
Contributor Author

vimalk78 commented Feb 2, 2024

Hello @opcm , can we get this merged?

opcm
opcm approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@opcm opcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I thought this was merged already. Thanks for the reminder

@opcm opcm merged commit 80c671b into intel:master Feb 2, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opcm opcm opcm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimalk78 @opcm