This repository has been archived by the owner on Aug 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a32543254
reviewed
Mar 21, 2024
a32543254
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you also add extension test, and post the benchmark data here? |
intellinjun
approved these changes
Mar 21, 2024
No need, seems chat GLM3 share same structure with chat GLM2. so we can treat them as one. |
yes. It's true. It's ok. I have added it. It also helps us to check convert / queantize / inference pipeline for GLM3. https://github.com/intel-innersource/frameworks.ai.lpot.lpot-validation/pull/623/files |
a32543254
reviewed
Mar 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
New Feature.
Description
Support ChatGLM3 in the Neural Speed.
Expected Behavior & Potential Risk
N/A
How has this PR been tested?
numactl -m 0 -C 0-55 python scripts/run.py /home/zhenzhong/model/chatglm3-6b/ -p "你好" --model_type=chatglm3
Dependency Change?
N/A