Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for imex-runner.py #615

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Add documentation for imex-runner.py #615

merged 1 commit into from
Jan 17, 2023

Conversation

silee2
Copy link
Contributor

@silee2 silee2 commented Jan 13, 2023

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

@silee2 silee2 added this to the v0.1 milestone Jan 13, 2023
@silee2
Copy link
Contributor Author

silee2 commented Jan 13, 2023

Addressing #539

Dewei-Wang-sh
Dewei-Wang-sh approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Dewei-Wang-sh Dewei-Wang-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nbpatel nbpatel merged commit 6bff666 into intel:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dewei-Wang-sh Dewei-Wang-sh Dewei-Wang-sh approved these changes

@nbpatel nbpatel nbpatel approved these changes

@mshahneo mshahneo Awaiting requested review from mshahneo

@drprajap drprajap Awaiting requested review from drprajap

@chencha3 chencha3 Awaiting requested review from chencha3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@silee2 @nbpatel @Dewei-Wang-sh